Page MenuHomePhabricator

Error in CI builds on patch test and gate-and-submit: "Error: your composer.lock file is not up to date"
Closed, ResolvedPublic

Description

Seen on multiple builds across extensions, e.g. https://gerrit.wikimedia.org/r/c/mediawiki/extensions/AbuseFilter/+/1062718 and https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CheckUser/+/1064132

Possibly related to T370380: mediawiki/core and mediawiki/vendor both skip composer.lock checks

From https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php74-noselenium/36699/consoleFull#console-section-12

10:30:58 INFO:quibble.commands:>>> Start: PHPUnit unit tests
10:30:58 INFO:quibble.commands:PHPUnit unit tests
10:30:58 INFO:quibble.commands:composer phpunit:unit -- --exclude-group Broken,ParserFuzz,Stub
10:30:59 > phpunit '--colors=always' '--testsuite=core:unit,extensions:unit,skins:unit' '--exclude-group' 'Broken,ParserFuzz,Stub'
10:30:59 Using PHP 7.4.33
10:30:59 Running without MediaWiki settings because there are no integration tests
10:30:59 wikimedia/minify: 2.8.0 installed, 2.7.0 required.
10:30:59 
10:30:59 Error: your composer.lock file is not up to date. Run "composer update" to install newer dependencies
10:30:59 PHPUnit 9.6.19 by Sebastian Bergmann and contributors.
10:30:59 
10:30:59 Error in bootstrap script: MediaWiki\Maintenance\MaintenanceFatalError:
10:30:59 
10:30:59 #0 /workspace/src/maintenance/checkComposerLockUpToDate.php(65): Maintenance->fatalError()
10:30:59 #1 /workspace/src/tests/common/TestSetup.php(217): CheckComposerLockUpToDate->execute()
10:30:59 #2 /workspace/src/tests/phpunit/bootstrap.php(183): TestSetup::maybeCheckComposerLockUpToDate()
10:30:59 #3 /workspace/src/vendor/phpunit/phpunit/src/Util/FileLoader.php(66): include_once('/workspace/src/...')
10:30:59 #4 /workspace/src/vendor/phpunit/phpunit/src/Util/FileLoader.php(49): PHPUnit\Util\FileLoader::load()
10:30:59 #5 /workspace/src/vendor/phpunit/phpunit/src/TextUI/Command.php(567): PHPUnit\Util\FileLoader::checkAndLoad()
10:30:59 #6 /workspace/src/vendor/phpunit/phpunit/src/TextUI/Command.php(347): PHPUnit\TextUI\Command->handleBootstrap()
10:30:59 #7 /workspace/src/vendor/phpunit/phpunit/src/TextUI/Command.php(114): PHPUnit\TextUI\Command->handleArguments()
10:30:59 #8 /workspace/src/vendor/phpunit/phpunit/src/TextUI/Command.php(99): PHPUnit\TextUI\Command->run()
10:30:59 #9 phpvfscomposer:///workspace/src/vendor/phpunit/phpunit/phpunit(106): PHPUnit\TextUI\Command::main()
10:30:59 #10 /workspace/src/vendor/bin/phpunit(118): include('phpvfscomposer:...')
10:30:59 #11 {main}
10:30:59 Script phpunit handling the phpunit event returned with error code 1
10:30:59 Script @phpunit --colors=always --testsuite=core:unit,extensions:unit,skins:unit was called via phpunit:unit
10:30:59 INFO:quibble.commands:<<< Finish: PHPUnit unit tests, in 1.279 s

Event Timeline

kostajh triaged this task as Unbreak Now! priority.Aug 29 2024, 8:40 AM
kostajh created this task.
kostajh added a subscriber: hashar.
kostajh added a subscriber: Krinkle.
kostajh renamed this task from Error: your composer.lock file is not up to date. to Error in CI builds on patch test and gate-and-submit: "Error: your composer.lock file is not up to date".Aug 29 2024, 8:43 AM
kostajh updated the task description. (Show Details)
hashar added a subscriber: Hokwelum.

@Hokwelum has approved both patches that were sent by @Krinkle originally .

I think what happened your patch slipped in between the two changes and thus were tested with mediawiki/vendor having the update but without mediawiki/core having received it. I think the process is to have both patch approved together so that is they eventually get merged more or less at the same time (there is still a short window of time during which build would fail though). I am happy to be corrected, I haven't really kept track of how updates to vendor can break CI.

Essentially the issue is transient and will be solved as soon as https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1065269 merges.

Redirectingto MediaWiki-Platform-Team since they own mediawiki/vendor nowadays.

kostajh claimed this task.

ah, thanks for the explanation. Tentatively resolving, then.