Page MenuHomePhabricator

collapsibleFooter arrows aren't correctly vertically aligned in skins other than Vector-2022
Closed, ResolvedPublicBUG REPORT

Assigned To
Authored By
Ebrahim
Aug 30 2024, 7:38 AM
Referenced Files
F57359135: image.png
Aug 30 2024, 4:24 PM
F57359089: image.png
Aug 30 2024, 4:24 PM
F57358589: image.png
Aug 30 2024, 3:42 PM
F57358581: image.png
Aug 30 2024, 3:42 PM
F57354046: image.png
Aug 30 2024, 7:38 AM
F57353982: image.png
Aug 30 2024, 7:38 AM

Description

This is a regression from https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1066438

Steps to replicate the issue (include links if applicable):

Open editor on some page with template or wikidata item usage or hidden category on a skin other than Vector-2022 like Minerva or MonoBook or Vector

What happens?:

image.png (192×341 px, 8 KB)

What should have happened instead?:
Like Vector-2022

image.png (192×341 px, 10 KB)

This perhaps comes from this line in my change, https://gerrit.wikimedia.org/g/mediawiki/core/+/ceeae9b74b416e7beae0bc77a3e4658840343608/resources/src/mediawiki.action/mediawiki.action.edit.collapsibleFooter.less#11 that spacing tries to replicate what <p> has in Vector-2022 which isn't true on other skins it seems.

The patch in https://phabricator.wikimedia.org/T373315#10095621 could fix this but that's blocked to a browser bug apparently.

Event Timeline

Ebrahim updated the task description. (Show Details)

Change #1069211 had a related patch set uploaded (by Ebrahim; author: Ebrahim):

[mediawiki/core@master] Fix vertical align of collapsibleFooter toggle across skins

https://gerrit.wikimedia.org/r/1069211

FWIW, Vector 2022 also looks weird to me, with margins that seem really big.

image.png (725×1 px, 132 KB)
image.png (725×1 px, 141 KB)

Currently

image.png (292×596 px, 32 KB)

Before my changes in 479790da927a52f08723ba59b92b2b58a9ce045b

image.png (272×574 px, 31 KB)

I think also things can be improved and guess that spacing will be normalized with my change but I was more there to remove the deprecated dependency.

Change #1069211 merged by jenkins-bot:

[mediawiki/core@master] Fix vertical align of collapsibleFooter toggle across skins

https://gerrit.wikimedia.org/r/1069211

matmarex assigned this task to Ebrahim.
matmarex removed a project: Patch-For-Review.

The above hasn't been backported afaik, however there was another glitch in prod, and that appears to have resolved itself. FYI in case it's useful to know / related:

The "Wikidata entities used in this page" section icon is glitching, seen below on Commons. Seems to affect all skins (Vector, Vector 22, Monobook).

Screenshot 2024-08-23 at 00.10.40.png (608×1 px, 121 KB)

Screenshot 2024-08-23 at 00.08.45.png (838×1 px, 228 KB)

The above hasn't been backported afaik, however there was another glitch in prod, and that appears to have resolved itself. FYI in case it's useful to know / related:

This is fixed in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/1065246 in the previous cut as it had an implicit dependency to Core's styles, see the incident report at T373315