Page MenuHomePhabricator

ChipInput: separate input + disabled styles are off
Closed, ResolvedPublic1 Estimated Story PointsBUG REPORT

Description

Steps to replicate the issue:

What happens?:

The input element is still white

image.png (192×1 px, 10 KB)

What should have happened instead?:

It should be background-color-disabled-subtle like the rest of the component

image.png (164×516 px, 14 KB)

Browsers: Firefox 130.0, Safari 17.3 (looks as expected in current Chrome)

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
CCiufo-WMF subscribed.

@AnneT I wonder if this is a browser-specific thing? It is working for me in Chrome 128.0.6613.120:

image.png (622×724 px, 38 KB)

@CCiufo-WMF Thanks for pointing that out! This looks fine in Chrome but broken in slightly different ways in FF and Safari

CCiufo-WMF triaged this task as Medium priority.Sep 23 2024, 2:51 PM
CCiufo-WMF lowered the priority of this task from Medium to Low.Sep 25 2024, 4:53 PM
CCiufo-WMF set the point value for this task to 1.
CCiufo-WMF moved this task from Needs Refinement to Up Next on the Design-System-Team board.
lwatson changed the task status from Open to In Progress.Oct 1 2024, 3:34 PM
lwatson claimed this task.

Change #1077063 had a related patch set uploaded (by LWatson; author: LWatson):

[design/codex@main] styles, ChipInput: fix separate input's disabled state

https://gerrit.wikimedia.org/r/1077063

Change #1077063 merged by jenkins-bot:

[design/codex@main] styles, ChipInput: fix separate input's disabled state

https://gerrit.wikimedia.org/r/1077063

Change #1080747 had a related patch set uploaded (by LWatson; author: LWatson):

[mediawiki/core@master] Update Codex from v1.13.1 to v1.14.0

https://gerrit.wikimedia.org/r/1080747

Change #1080747 merged by jenkins-bot:

[mediawiki/core@master] Update Codex from v1.13.1 to v1.14.0

https://gerrit.wikimedia.org/r/1080747