Page MenuHomePhabricator

Incorrect FlaggedRevs page status message
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue

  • open a page with stable/checked FlaggedRevs version, e.g. this page
  • the message on the top right corner says Pending
  • but when you place the cursor over the message, the status of the page is This is a checked version of this page

kép.png (353×337 px, 11 KB)

  • open a page with pending FlaggedRevs version, e.g. this page
  • the message on the top right corner says Pending
  • but the status of the page is Pending changes are displayed on this page

kép.png (327×513 px, 15 KB)

What happens?: the current state is very confusing. Although the two cases are different, the status message is identical, so you cannot be sure whether the page is actually being checked (no action required) or not (patrolling required).

What should have happened instead?: the message should be revised

Event Timeline

I investigated this a bit, it only happens when low profile is turned off and it's on "indicator" mode (simple ui?). It only affects a small set of wikis.

Change #1076811 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/extensions/FlaggedRevs@master] Fix showing incorrect indicator when the page is stable

https://gerrit.wikimedia.org/r/1076811

Change #1076811 merged by jenkins-bot:

[mediawiki/extensions/FlaggedRevs@master] Fix showing incorrect indicator when the page is stable

https://gerrit.wikimedia.org/r/1076811

Ladsgroup closed this task as Resolved.EditedSep 30 2024, 9:22 PM
Ladsgroup claimed this task.

It'll be fixed by the next train.