Page MenuHomePhabricator

Warning about username not existing shown on Special:GlobalContributions when target validation failed because target must be IP or IP range
Open, Needs TriagePublic

Description

When a user loads Special:GlobalContributions for a username target, they are informed that the tool does not accept usernames. This is because the tool currently only supports IP addresses and ranges, though will be later updated to support temporary accounts (and named accounts too).

However, when entering a username target that does not exist, the form shows the validation error but also has a warning that says that the username does not exist. Given that a username is not a valid target, we should probably be hiding this warning from the page as it may be confusing (as it could imply that existing username targets are valid).

An example of this problem is shown below:

image.png (715×971 px, 31 KB)

Event Timeline

Change #1092862 had a related patch set uploaded (by STran; author: STran):

[mediawiki/extensions/CheckUser@master] Hide username warnings while usernames are unsupported by Special:GlobalContributions

https://gerrit.wikimedia.org/r/1092862

Change #1092862 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Hide username warnings while usernames are unsupported by Special:GlobalContributions

https://gerrit.wikimedia.org/r/1092862

@STran:
At the IP Address or Range textfield:
When using a Temporary Account or a registered Username, I am seeing an error message that says "isn't a valid username"...
Is that the expected verbiage when a registered Username or Temporary Account is entered or should it say "Enter a valid IP Address or IP Range"?

image.png (491×1 px, 59 KB)

image.png (459×1 px, 54 KB)