Page MenuHomePhabricator
Create Task
Maniphest T377030

Wikitech showing Wikipedia CentralNotice banners
Closed, ResolvedPublic
Actions

Description

To reproduce:

Expected result:

Actual result:

  • See a CentralNotice banner

We know this is banners targeted at Wikipedia projects, since it happened yesterday with fundraising banners which are only ever targeted at Wikipedia. I did fix fundraising banners to hide them if loaded on Wikitech, but other banners can still be shown.

We could do the same as T270308: API portal showing Wikipedia CentralNotice banners and hide CentralNotice banners on Wikitech. But it would probably be better to add it as a proper target site if possible

Details

SubjectRepoBranchLines +/-
Make wikitech a target for CentralNotice bannersoperations/mediawiki-configmaster+2 -0
Customize query in gerrit

Related Objects

Event Timeline

Pcoombe created this task.Fri, Oct 11, 5:36 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFri, Oct 11, 5:36 PM
AKanji-WMF triaged this task as High priority.Tue, Oct 15, 7:47 PM
AKanji-WMF moved this task from Triage to DRI Backlog on the Fundraising-Backlog board.
AKanji-WMF added a project: Fundraising Tech - Chaos Crew.
Ejegg moved this task from Backlog to Ready for Review on the Fundraising Tech - Chaos Crew board.Wed, Oct 16, 6:06 PM
Ejegg moved this task from Ready for Review to Backlog on the Fundraising Tech - Chaos Crew board.
gerritbot added a comment.Wed, Oct 16, 6:10 PM

Change #1080780 had a related patch set uploaded (by Ejegg; author: Ejegg):

[operations/mediawiki-config@master] Make wikitech a target for CentralNotice banners

https://gerrit.wikimedia.org/r/1080780

gerritbot added a project: Patch-For-Review.Wed, Oct 16, 6:10 PM
Ejegg moved this task from Backlog to Ready for Review on the Fundraising Tech - Chaos Crew board.Wed, Oct 16, 6:11 PM
gerritbot added a comment.Wed, Oct 16, 8:15 PM

Change #1080780 merged by jenkins-bot:

[operations/mediawiki-config@master] Make wikitech a target for CentralNotice banners

https://gerrit.wikimedia.org/r/1080780

Stashbot added a comment.Wed, Oct 16, 8:17 PM

Mentioned in SAL (#wikimedia-operations) [2024-10-16T20:17:00Z] <jhuneidi@deploy2002> Started scap sync-world: Backport for [[gerrit:1080780|Make wikitech a target for CentralNotice banners (T377030)]]

Stashbot added a comment.Wed, Oct 16, 8:18 PM

Mentioned in SAL (#wikimedia-operations) [2024-10-16T20:18:50Z] <jhuneidi@deploy2002> ejegg, jhuneidi: Backport for [[gerrit:1080780|Make wikitech a target for CentralNotice banners (T377030)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Stashbot added a comment.Wed, Oct 16, 8:26 PM

Mentioned in SAL (#wikimedia-operations) [2024-10-16T20:26:23Z] <jhuneidi@deploy2002> Finished scap sync-world: Backport for [[gerrit:1080780|Make wikitech a target for CentralNotice banners (T377030)]] (duration: 10m 02s)

Maintenance_bot removed a project: Patch-For-Review.Wed, Oct 16, 8:30 PM
Ejegg moved this task from Ready for Review to Done on the Fundraising Tech - Chaos Crew board.Wed, Oct 16, 8:45 PM
Ejegg subscribed.

Hi @Pcoombe, I just got a settings patch deployed to add wikitech as a separate target for CentralNotice. Let me know if it works for you!

jeremyb assigned this task to Ejegg.Thu, Oct 17, 3:51 AM
jeremyb subscribed.

@Ejegg

looks good to me. I saw no banner there and then added Wikitech to an active campaign and then removed Wikitech from campaign and was still seeing it and then didn't see it and then deleted impressiondiet from session data locally in my browser and then saw it again (not in allocation but still within the 10 minute caching period) then waited for 10 minutes to expire and deleted impressiondata again and then it really doesn't appear. then did another test to see what shows in allocation, turned same campaign on for Wikitech and showed up immediately in allocation and then removed Wikitech from campaign and disappeared immediately from allocation.

https://meta.wikimedia.org/wiki/Special:CentralNoticeLogs?log_type=campaignSettings&startDate=2024-10-17&startDate_timestamp=20241017000000&endDate=2024-10-18&endDate_timestamp=20241018000000&campaign=Wikidata_Day_NYC&user=jeremyb&centralnoticesubmit=Apply+filters

Pcoombe closed this task as Resolved.Thu, Oct 17, 2:51 PM

Looks good to me as well. Thanks @Ejegg, and thanks @jeremyb for testing!

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits