Page MenuHomePhabricator

MPIC: Error thrown if optional description field is left empty
Open, MediumPublic1 Estimated Story PointsBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • Access MPIC either on staging or production.
  • Open the form for creating a new data collection artifact
  • Provide all the necessary details but leave the "Description" field empty (note that it is labeled as optional)
  • Attempt to submit the form

What happens?:

A validation error is thrown, stating that the "Description" field has an invalid value, even though the field is marked as optional. The error message displayed is:

"There are some errors while validating the form description: Invalid value"

(See attached screenshot)

What should have happened instead?:

Since the "Description" field is optional, the form should submit successfully without requiring a value for this field. No validation error should be triggered if the field is left empty.

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Detected using Chrome v129 on MacOS Sonoma 14.6.1.

description-validation.png (1×3 px, 689 KB)

Event Timeline

Milimetric triaged this task as Medium priority.Nov 12 2024, 3:16 PM
Milimetric moved this task from NEEDS DISCUSSION to MPIC Alpha Scope on the Experimentation Lab board.

This bug was already confirmed as valid. description should be an optional field but the validator we have implemented so far in the backend is not allowing an empty value. That rule should be removed

Sfaci set the point value for this task to 1.Nov 13 2024, 8:48 PM

Change #1100502 had a related patch set uploaded (by Clare Ming; author: Clare Ming):

[operations/deployment-charts@master] Metrics Platform Instrument/Experiment Configurator: Deploying to staging

https://gerrit.wikimedia.org/r/1100502

Change #1100504 had a related patch set uploaded (by Clare Ming; author: Clare Ming):

[operations/deployment-charts@master] Metrics Platform Instrument/Experiment Configurator: Deploying to production

https://gerrit.wikimedia.org/r/1100504

Change #1100504 merged by jenkins-bot:

[operations/deployment-charts@master] Metrics Platform Instrument/Experiment Configurator: Deploying to production

https://gerrit.wikimedia.org/r/1100504

Change #1100502 merged by jenkins-bot:

[operations/deployment-charts@master] Metrics Platform Instrument/Experiment Configurator: Deploying to staging

https://gerrit.wikimedia.org/r/1100502

Test status: QA PASS

Test environment: Staging