Page MenuHomePhabricator

While editing labels in the Wikifunctions "About", the "Cancel" and "Publish" buttons may overflow
Closed, ResolvedPublicBUG REPORT

Description

I tried editing Z1005 and Z18784 with the Russian user interface, and it looked like this:

צילום מסך מ־2024-10-16 18-47-16.png (726×830 px, 54 KB)

I think that the problem is obvious from the screenshot, but if it isn't, I'm happy to add details.

It doesn't overflow on my laptop when I use Wikifunctions in English, but it happens consistently on all pages in Russian.

It also happens in Italian:

תמונה.png (711×545 px, 72 KB)

It probably has something to do with the length of the translation of the message wikilambda-about-widget-title. This message is short in English and German, so it doesn't happen there, but it's longer in Russian and Italian, so it breaks.

In Chechen (ce), it's two words, so something a bit weird happens: Before editing, the "About" label is shown in one line, but when editing, it becomes two lines. Screenshot:

תמונה.png (711×545 px, 72 KB)

Event Timeline

Jdforrester-WMF subscribed.

Design question: What should happen when the labels are long? Collapse buttons to icons? Render as a stack?

These buttons currently end up in a very weird place DOM-navigation/order wise. When you enter the edit label mode you need to tab-backwards to access them rather then accessing them after the inputs.

These two issues could be solved by moving the buttons to the end of the form and let them stack when the sidebar gets narrow.

Change #1133329 had a related patch set uploaded (by Daphne Smit; author: Daphne Smit):

[mediawiki/extensions/WikiLambda@master] While editing labels in the Wikifunctions "About", the "Cancel" and "Publish" buttons may overflow

https://gerrit.wikimedia.org/r/1133329

Wrapped into new line when the About box is smaller, but still in the same line on views where the About box takes the whole screen:

Screenshot from 2025-04-02 16-57-41.png (997×793 px, 76 KB)

Screenshot from 2025-04-02 16-57-49.png (939×790 px, 59 KB)

Change #1133329 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] While editing labels in the Wikifunctions "About", the "Cancel" and "Publish" buttons may overflow

https://gerrit.wikimedia.org/r/1133329

This was one of the tasks suggested by Amin earlier for me to work on. But it seems it has already been done, is that right @gengh @DSmit-WMF ?

DSantamaria changed the task status from Open to In Progress.Apr 7 2025, 7:56 AM

Change #1134667 had a related patch set uploaded (by Daphne Smit; author: Daphne Smit):

[mediawiki/extensions/WikiLambda@master] Add wrap of cancel and save buttons in edit of About

https://gerrit.wikimedia.org/r/1134667

Change #1134667 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Add wrap of cancel and save buttons in edit of About

https://gerrit.wikimedia.org/r/1134667

Fixed experience in production:

image.png (2,076×1,620 px, 188 KB)