Page MenuHomePhabricator

Update LogFormatter / BlockLogFormatter to support multiblocks
Open, Needs TriagePublic

Description

Background

When viewing Special:Contributions for a blocked user (example), the current block is shown at the top:

Screenshot from 2024-10-24 17-57-32.png (191×1 px, 43 KB)

With Multiblocks enabled, we'll need to show all existing blocks. Something like (pretend there are multiple rows):

Screenshot from 2024-10-24 17-49-58.png (163×1 px, 46 KB)

Acceptance criteria

Modify the existing LogFormatter and/or BlockLogFormatter classes to support multiblocks.

When viewing Special:Log/block :

  • List each individual block as a separate log entry (this may already be the case)
  • The "unblock" link should link to Special:Unblock/<username/IP>
  • A "remove block" link should also be added, deep linking to Special:Unblock?id=123 (see T378144)
  • The "change block" link should deep link to Special:Block?id=123 (see T378140)

When viewing Special:Contribs/BlockedUser:

  • Message should instead say "There are currently N blocks on this user:"
  • List each active block in the same format as described above

Should it be in Codex?: NO

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

This proposal makes sense without "codexifying" it.

Change #1102669 had a related patch set uploaded (by Tim Starling; author: Tim Starling):

[mediawiki/core@master] block: Show a special log entry when blocking an already blocked target

https://gerrit.wikimedia.org/r/1102669

Cparle updated the task description. (Show Details)

@MusikAnimal is it possible to instead direct the user to Special:Block with the block loaded, so they can remove the block from the Special:Block page?

MusikAnimal is it possible to instead direct the user to Special:Block with the block loaded, so they can remove the block from the Special:Block page?

Discussed on Slack, but yes a Special:Block?unblockId=123 is very doable, but we don't currently have something that works for no-JS users.

As discussed in standup on Dec 19, we plan to update LogFormatter so that instead of two links (1 link for Special:Unblock and 1 link for Special:Block), we want to move towards 1 "Manage block" link, which would pass the target and/or blockID into the Special:Block page, and pre-populate it with the target.

This will help us decrease traffic to Special:Unblock.