Page MenuHomePhabricator

mw-hiero-box is not dark mode compatible
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

What happens?:
the top and bottom part of the cartouche stay black because the class mw-hiero-box has a hardcoded background color of #000

What should have happened instead?:
the whole cartouche should be white in dark mode.

I would have tried to fix this myself but I'm unsure what would be a fitting token to use instead of #000. In the weird WikiHiero output, mw-hiero-box is a background that looks like a border in a multiply nested table.

Event Timeline

background-color-base is the closest token I think, but doesn't match #000, no. This is a task for Design-System-Team to decide I think.

background-color-inverted works quite well, thoughts @Izno @hzgh? background-color-base is actually the wrong colour since it's white in light mode.

Uh, it might not have existed then, but also I think I drped a bit there. inverted seems as fine as anything.

That said, in some world where these aren't tables, that is probably a border and not a background, and I don't think there's a token for a border like inverted...

Change #1152256 had a related patch set uploaded (by Matr1x; author: Matr1x):

[mediawiki/extensions/wikihiero@master] WikiHiero: Add dark mode compatibility and implement Codex design tokens

https://gerrit.wikimedia.org/r/1152256

ok, I guess patch demo doesn't support wikihiero, so testing was a bit more involved.

Change #1152256 merged by jenkins-bot:

[mediawiki/extensions/wikihiero@master] Add dark mode compatibility and implement Codex design tokens

https://gerrit.wikimedia.org/r/1152256

Test wiki on Patch demo by TheDJ using patch(es) linked to this task was deleted:

https://patchdemo.wmcloud.org//wikis/77db4ce661/w/