Page MenuHomePhabricator

Special:GlobalContributions should not be includable
Closed, ResolvedPublic

Description

Special:GlobalContributions extends ContributionsSpecialPage, which extends IncludableSpecialPage.

Includable special pages allow for transcluding content, so e.g. {{Special:Contributions/Foo}} would render the contributions from the user Foo on a page.

For Special:GlobalContributions, we don't want that functionality (it currently doesn't work anyway) because this page has restricted access, and we need to be able to log access.

Let's set isIncludable() to false for this page.

Event Timeline

Change #1083834 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/CheckUser@master] GlobalContributions: Do not allow transclusion

https://gerrit.wikimedia.org/r/1083834

Change #1083834 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] GlobalContributions: Do not allow transclusion

https://gerrit.wikimedia.org/r/1083834

In the interest of reducing QA burden, marking this as resolved.

Change #1085630 had a related patch set uploaded (by Tchanders; author: Tchanders):

[mediawiki/extensions/CheckUser@master] GlobalContributions: Do not allow transclusion

https://gerrit.wikimedia.org/r/1085630

Change #1085630 had a related patch set uploaded (by Tchanders; author: Tchanders):

[mediawiki/extensions/CheckUser@master] GlobalContributions: Do not allow transclusion

https://gerrit.wikimedia.org/r/1085630

Tagged this task by mistake. Corrected in the commit message to T378727: PermissionsError: The action you have requested is limited to users in one of the groups: <groups>.