Page MenuHomePhabricator
Create Task
Maniphest T380604

Make provideLuaData static
Closed, ResolvedPublic
Actions

Description

in Wikibase/client/tests/phpunit/integration/includes/DataAccess/Scribunto/WikibaseLibraryInProcessEntityCacheTest.php:
provideLuaData is a non-static dataProvider function. It can't be made static without also changing files in other extensions:

  • extensions/Scribunto
    • tests/phpunit/Engines/LuaCommon/LuaEngineTestBase.php
    • tests/phpunit/Engines/LuaCommon/LuaEngineUnitTestBase.php
  • extensions/Capiunto
    • tests/phpunit/output/BasicRowTest.php
    • tests/phpunit/output/BasicTest.php

To avoid breaking CI, this change needs to happen in a multistep process across the affected repos.

Details

SubjectRepoBranchLines +/-
provideLuaData - remove override, make stub version staticmediawiki/extensions/Wikibasemaster+4 -8
Skip tests while `provideLuaData` is made staticmediawiki/extensions/Capiuntomaster+10 -4
Skip tests while `provideLuaData` is made staticmediawiki/extensions/Wikibasemaster+9 -7
Customize query in gerrit

Related Objects
Search...

Event Timeline

AudreyPenven_WMDE created this task.Nov 22 2024, 3:19 PM
Restricted Application removed a project: Patch-For-Review. · View Herald TranscriptNov 22 2024, 3:19 PM
AudreyPenven_WMDE removed projects: MW-1.44-notes (1.44.0-wmf.4; 2024-11-19), MW-1.41-notes (1.41.0-wmf.12; 2023-06-06).Nov 22 2024, 3:27 PM
AudreyPenven_WMDE moved this task from In Task Breakdown to In Development on the Wikidata Dev Team (Wikidata.org Slice) board.
gerritbot added a comment.Nov 22 2024, 4:33 PM

Change #1094483 had a related patch set uploaded (by Audrey Penven; author: Audrey Penven):

[mediawiki/extensions/Wikibase@master] Temporarily skip tests using `provideLuaData`

https://gerrit.wikimedia.org/r/1094483

gerritbot added a project: Patch-For-Review.Nov 22 2024, 4:33 PM
gerritbot added a comment.Nov 25 2024, 3:39 PM

Change #1097415 had a related patch set uploaded (by Audrey Penven; author: Audrey Penven):

[mediawiki/extensions/Capiunto@master] Skip tests while `provideLuaData` is made static

https://gerrit.wikimedia.org/r/1097415

Lucas_Werkmeister_WMDE mentioned this in T337154: Make PHPUnit dataProvider static in Wikibase tests.Nov 25 2024, 5:24 PM
gerritbot added a comment.Wed, Nov 27, 4:55 PM

Change #1097415 abandoned by Audrey Penven:

[mediawiki/extensions/Capiunto@master] Skip tests while `provideLuaData` is made static

https://gerrit.wikimedia.org/r/1097415

gerritbot added a comment.Wed, Nov 27, 4:55 PM

Change #1094483 abandoned by Audrey Penven:

[mediawiki/extensions/Wikibase@master] Skip tests while `provideLuaData` is made static

https://gerrit.wikimedia.org/r/1094483

AudreyPenven_WMDE added a comment.Wed, Nov 27, 4:57 PM

making provideLuaData static in Scribunto is covered in T337135

gerritbot added a comment.Wed, Nov 27, 5:06 PM

Change #1098566 had a related patch set uploaded (by Audrey Penven; author: Audrey Penven):

[mediawiki/extensions/Wikibase@master] Remove override implementation of provideLuaData

https://gerrit.wikimedia.org/r/1098566

AudreyPenven_WMDE removed AudreyPenven_WMDE as the assignee of this task.Wed, Nov 27, 5:18 PM
AudreyPenven_WMDE moved this task from In Development to Ready for Peer Review on the Wikidata Dev Team (Wikidata.org Slice) board.
AudreyPenven_WMDE claimed this task.Thu, Nov 28, 11:06 AM
AudreyPenven_WMDE moved this task from Ready for Peer Review to In Development on the Wikidata Dev Team (Wikidata.org Slice) board.
gerritbot added a comment.Thu, Nov 28, 4:07 PM

Change #1098566 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] provideLuaData - remove override, make stub version static

https://gerrit.wikimedia.org/r/1098566

Lucas_Werkmeister_WMDE closed this task as Resolved.Thu, Nov 28, 4:14 PM
Lucas_Werkmeister_WMDE moved this task from In Development to Done on the Wikidata Dev Team (Wikidata.org Slice) board.

This is done as far as Wikibase is concerned (the rest is covered in T337135 as mentioned above).

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.6; 2024-12-03).Thu, Nov 28, 5:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits