Page MenuHomePhabricator
Create Task
Maniphest T381147

Unified Dashboard: Initial suggestions should not be refreshed when a previously selected filter is selected again
Open, MediumPublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

  1. Visit CX Unified Dashboard
  2. Select a new suggestion filter
  3. Select the previously selected filter again

What happens?:
Initial suggestions for the originally selected filter are refreshed and a new suggestions slice is displayed.

What should have happened instead?:
The same suggestions that were initially displayed should be displayed again. If the user wants to refresh these suggestions, they can click on the "Refresh suggestions" button.

Screencast:

Derived Requirement

Ensure that the initial suggestions are not refreshed when a previously selected filter is selected again in the CX Unified Dashboard. The suggestions should only refresh when the user explicitly clicks the "Refresh suggestions" button.

Test Steps

Test Case 1: Ensure Suggestions Are Not Refreshed When Previously Selected Filter Is Selected Again

  1. Visit the CX Unified Dashboard.
  2. Select a suggestion filter (e.g., "Filter A").
  3. Observe and note the suggestions displayed.
  4. Select a different filter (e.g., "Filter B") to change the suggestions.
  5. Re-select the previously selected filter ("Filter A").
  6. ✅❓❌⬜ AC1: Verify that the suggestions displayed for the re-selected filter ("Filter A") remain the same as initially shown, without refreshing.

QA Results - Test Mobile ContentTranslation

ACStatusDetails
1✅T381147#10407729

Details

SubjectRepoBranchLines +/-
CX3 Build 0.2.0+20241202mediawiki/extensions/ContentTranslationmaster+4 K -4 K
Display next suggestion slice only when refresh button is clickedmediawiki/extensions/ContentTranslationmaster+24 -15
Customize query in gerrit

Event Timeline

ngkountas created this task.Fri, Nov 29, 9:28 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFri, Nov 29, 9:28 AM
ngkountas claimed this task.Fri, Nov 29, 9:29 AM
ngkountas triaged this task as Medium priority.
ngkountas added projects: OKR-Work, SectionTranslation.
ngkountas moved this task from Prioritized to In-progress on the LPL Hypothesis board.
gerritbot added a comment.Fri, Nov 29, 9:41 AM

Change #1099160 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] Display next suggestion slice only when refresh button is clicked

https://gerrit.wikimedia.org/r/1099160

gerritbot added a project: Patch-For-Review.Fri, Nov 29, 9:41 AM
ngkountas moved this task from In-progress to Needs Code Review on the LPL Hypothesis board.Fri, Nov 29, 9:41 AM
gerritbot added a comment.Mon, Dec 2, 2:57 PM

Change #1099160 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] Display next suggestion slice only when refresh button is clicked

https://gerrit.wikimedia.org/r/1099160

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.6; 2024-12-03).Mon, Dec 2, 3:00 PM
SBisson moved this task from Needs Code Review to Pending deployment on the LPL Hypothesis board.Mon, Dec 2, 3:01 PM
SBisson removed a project: Patch-For-Review.
gerritbot added a comment.Mon, Dec 2, 5:56 PM

Change #1099753 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] CX3 Build 0.2.0+20241202

https://gerrit.wikimedia.org/r/1099753

gerritbot added a project: Patch-For-Review.Mon, Dec 2, 5:56 PM
gerritbot added a comment.Mon, Dec 2, 7:45 PM

Change #1099753 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] CX3 Build 0.2.0+20241202

https://gerrit.wikimedia.org/r/1099753

Maintenance_bot removed a project: Patch-For-Review.Mon, Dec 2, 8:38 PM
SBisson moved this task from Pending deployment to Needs QA on the LPL Hypothesis board.Fri, Dec 6, 3:59 PM
GMikesell-WMF updated the task description. (Show Details)Mon, Dec 16, 11:07 PM
GMikesell-WMF updated Other Assignee, added: GMikesell-WMF.
GMikesell-WMF subscribed.Mon, Dec 16, 11:10 PM

@ngkountas It is verified that the suggestions displayed for the re-selected filter ("Women's Health") remain the same as initially shown, without refreshing as seen in the gif. I will move this to sign-off. Thanks for all your work!

**Test Result - Test Mobile ContentTranslation*

Status: ✅ PASS
Environment: Test Mobile ContentTranslation
OS: macOS Sonoma 15.1
Browser: Chrome 131
Device: MBA
Emulated Device: NA

Test Artifact(s):

Test Steps

Test Case 1: Ensure Suggestions Are Not Refreshed When Previously Selected Filter Is Selected Again

  1. Visit the CX Unified Dashboard.
  2. Select a suggestion filter (e.g., "Women's Health").
  3. Observe and note the suggestions displayed.
  4. Select a different filter (e.g., "For you") to change the suggestions.
  5. Re-select the previously selected filter ("Women's Health").
  6. ✅ *AC1:** Verify that the suggestions displayed for the re-selected filter ("Filter A") remain the same as initially shown, without refreshing.

2024-12-16_15-02-52.mp4.gif (782×686 px, 1 MB)

GMikesell-WMF updated the task description. (Show Details)Mon, Dec 16, 11:11 PM
GMikesell-WMF updated Other Assignee, removed: GMikesell-WMF.
GMikesell-WMF moved this task from Needs QA to Design Signoff on the LPL Hypothesis board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits