| KColeman-WMF | |
| Fri, Nov 29, 10:24 PM |
| F57777360: image.png | |
| Thu, Dec 5, 7:54 AM |
| F57775299: image.png | |
| Tue, Dec 3, 3:15 PM |
| F57774835: image.png | |
| Tue, Dec 3, 11:07 AM |
| F57774808: image.png | |
| Tue, Dec 3, 11:07 AM |
| F57774797: image.png | |
| Tue, Dec 3, 11:07 AM |
| F57762142: footer-placement.png | |
| Fri, Nov 29, 10:24 PM |
Steps to replicate the issue (include links if applicable):
What happens?:
What should have happened instead?:
Change #1099715 had a related patch set uploaded (by Harroyo-wmf; author: Harroyo-wmf):
[mediawiki/extensions/ReportIncident@master] dialog: Don't duplicate the footer in the behaviour list temmplate
@KColeman-WMF the designs in Figma show that the screen to select the type of behavior does not have an icon in the left side of the footer message that says "Pressing continue will..."
However, in our current implementation we show the 
cdxIconUserGroup icon for that step too. That's because we use the same Codex message for all steps, which happens to expect an icon that we switch depending on the particular flow the user is taking (emergency/non-emergency). All other screens in Figma, except the last one, show an icon in the left side of the footer.
I already have a draft fix to hide the icon in that screen but, just for confirmation, is it expected for that screen to not have an icon in the left side?
@KColeman-WMF the designs in Figma show that the screen to select the type of behavior does not have an icon in the left side of the footer message that says "Pressing continue will..."
However, in our current implementation we show the
I already have a draft fix to hide the icon in that screen but, just for confirmation, is it expected for that screen to not have an icon in the left side?
Yes, that's correct. There should be no icon icon on this screen. Thanks for checking!
Change #1099715 merged by jenkins-bot:
[mediawiki/extensions/ReportIncident@master] dialog: Don't duplicate the footer in the behaviour list template
Change #1100117 had a related patch set uploaded (by Kosta Harlan; author: Harroyo-wmf):
[mediawiki/extensions/ReportIncident@wmf/1.44.0-wmf.6] dialog: Don't duplicate the footer in the behaviour list template
The main fix in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/ReportIncident/+/1099715 has been merged.
A separate change https://gerrit.wikimedia.org/r/c/mediawiki/extensions/ReportIncident/+/1100117 has been opened to backport the fix.
The fix to move the text to the footer and remove the icon has been merged and is ready for QA.
Change #1100117 merged by jenkins-bot:
[mediawiki/extensions/ReportIncident@wmf/1.44.0-wmf.6] dialog: Don't duplicate the footer in the behaviour list template
Mentioned in SAL (#wikimedia-operations) [2024-12-04T08:13:18Z] <kharlan@deploy2002> Started scap sync-world: Backport for [[gerrit:1100117|dialog: Don't duplicate the footer in the behaviour list template (T381189)]]
Mentioned in SAL (#wikimedia-operations) [2024-12-04T08:18:27Z] <kharlan@deploy2002> kharlan: Backport for [[gerrit:1100117|dialog: Don't duplicate the footer in the behaviour list template (T381189)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)
Mentioned in SAL (#wikimedia-operations) [2024-12-04T08:25:26Z] <kharlan@deploy2002> Finished scap sync-world: Backport for [[gerrit:1100117|dialog: Don't duplicate the footer in the behaviour list template (T381189)]] (duration: 12m 08s)
QA is completed...
Footer text now appears in dialog footer.
