magicLinkCallback does not support protocol-relative URLs
Closed, InvalidPublic

Description

The PMID magic link does not support a protocol-relative URL. For example:

PMID 12122621

Will always direct to http:// even when you are logged onto the secure server.

The RFC magic link does supports a protocol-relative URL.


Version: 1.20.x
Severity: normal

bzimport added a subscriber: wikibugs-l.
bzimport set Reference to bz36639.
Gadget850 created this task.Via LegacyMay 8 2012, 1:50 PM
Krinkle added a comment.Via ConduitMay 8 2012, 9:40 PM

PMID and RFC magic links (and others) are detected from the Parser::magicLinkCallback method.

The urls themselves are defined in interface messages:

Both the PMID and RFC messages are are set to protocol-relative urls

And testing it in a sandbox:
https://www.mediawiki.org/w/index.php?title=Project:Sandbox&oldid=534856

Shows that they are working fine.

Krinkle added a comment.Via ConduitMay 8 2012, 9:41 PM

Accessing it through the secure HTTPS server:
https://www.mediawiki.org/w/index.php?title=Project:Sandbox&oldid=534856

Also works. Please re-open if this is still a problem.

Gadget850 added a comment.Via ConduitMay 8 2012, 11:28 PM

Krinkle: Your sandbox works for me.

But not on the English Wikipedia:

https://en.wikipedia.org/wiki/User:Gadget850/Bug_36639

Hazard-SJ added a comment.Via ConduitMay 8 2012, 11:42 PM

I'd assume the change was not deployed there as yet.

Krinkle added a comment.Via ConduitMay 8 2012, 11:51 PM

No, it was changed in november 2011:

https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/core.git;a=commit;h=08a311234de6a76cc6d737fb1704245fa93951e8

en.wikipedia community locally changed their PMID url:

https://en.wikipedia.org/w/index.php?title=MediaWiki:Pubmedurl&action=history

The RFC one does work on en.wikipedia.org

Krinkle added a comment.Via ConduitMay 8 2012, 11:56 PM

I've requested the local change to be deleted on en.wikipedia.org.

Resolving this bug as INVALID since this is not a bug in the mediawiki software.

Hazard-SJ added a comment.Via ConduitMay 9 2012, 12:31 AM

Okay.

Gadget850 added a comment.Via ConduitMay 9 2012, 12:35 AM

Thanks. Didn't know that was there.

Add Comment