When two revisions of a Wikidata item are selected, a diff should be created and displayed.
Version: unspecified
Severity: normal
Description
Description
Details
Details
- Reference
- bz37496
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | daniel | T39496 Display a diff between two revisions of a Wikidata item | |||
| Resolved | None | T39680 ItemDiff does not work for label and description | |||
| Resolved | daniel | T39747 Adjust diff headers in Wikibase\DifferenceEngine | |||
| Resolved | None | T39683 Implement revert/undo for Wikibase Items | |||
| Resolved | None | T41428 undo/restore may fail due to sitelink conflicts | |||
| Resolved | None | T39991 implement reset for data items | |||
| Resolved | None | T40179 Test revert for items | |||
| Resolved | None | T40178 Implement undo for items |
Event Timeline
Comment Actions
Implementation is in gerrit for review: https://gerrit.wikimedia.org/r/11865
I have implemented this based on the normal wikitext diff, using the same side-by-side layout and recycling the CSS. As a context (instead of the line number), the path to the changed value is shown, using the keys from our internal JSON representation. That sucks, of course.
This implementation doesn't work correctly at the moment, because it depends on some other things to be fixed, most importantly bug 37680, but also bug 37691 and bug 37683.
Anyway, some actual UI design seems in Order here. Some thoughts:
- side-by-side seems useless.
- instead, show added, removed and modified properties in a single column
- for modified properties, show a word-based diff
- it may be nice to just show the (old) item with highlighted modifications (inline diff)
- diffs will often be for a single atomic change. It could be useful to make this a special case.