Can you please check grammar of messages in Access Control extension? I think there are several grammatical problems.
This issue was reported by a translatewiki.net translator.
Version: master
Severity: normal
URL: https://translatewiki.net/wiki/Thread:Support/Access_Control_extension
| Status | Subtype | Assigned | Task | |
|---|---|---|---|---|
| · · · | ||||
| Invalid | None | T40638 [DO NOT USE] Interface messages needing rewording or documentation and other issues with existing messages [superseded by #Voice_&_Tone] | ||
| Declined | None | T39670 Grammar problems with UI messages | ||
| · · · |
I don't think that creating Bugzilla components without asking the extension author makes any sense, and this feels like a case of it. I hope I'm wrong. :)
(In reply to comment #2)
I don't think that creating Bugzilla components without asking the extension
author makes any sense, and this feels like a case of it. I hope I'm wrong.
Not sure what you mean, Andre. My opinion is that there shouldn't be an extension repo without a bugzilla component and a maintainer, as that would make it impossible to track issues for it and would make our gerrit repos places to dump code. Please let me know if that no brainer is different in our view.
Ah, the extension maintainer has a Bugzilla account. That's great.
In that case sorry for my comment 2, it doesn't apply.
Adding many blockers of bug 38638 to the list of "easy" bugs, to mark them as candidates for [[mw:Google Code-in]] tasks (gci2013). If you think this bug is not suitable, remove the keyword.
sumanah wrote:
Aravind, to answer your question from IRC:
Yes, AccessControl.i18n.php is indeed the file to change.
https://www.mediawiki.org/wiki/Localisation#Message_sources That might be helpful. Probably the .i18n.php file is the source of the strings, the "messages", you need to change.
aravikn wrote:
Oh. Thanks Sumana. Another problem that I find is that the "messages" present inside this are not grammatically incorrect.
Aravind: Please provide a specific example (in case it is still related to the topic for this bug report and not a separate problem that should be in a separate report).
aravikn wrote:
Sumana,
These are the messages. I don't find any grammatical errors with these.
$messages['en'] = array(
'accesscontrol-desc' => 'Enables group access restriction on a page by user basis',
'accesscontrol-info' => 'This is a protected page!',
'accesscontrol-move-anonymous' => 'Deny_anonymous_by_include',
'accesscontrol-move-users' => 'Deny_user_by_include',
'accesscontrol-redirect-anonymous' => 'Deny_anonymous',
'accesscontrol-redirect-users' => 'Deny_user',
'accesscontrol-actions-deny' => 'Deny_action',
);
aravikn wrote:
I think this bug has been fixed. I checked the file and I did not find any grammatical errors as I have already mentioned. So I think the bug has already been fixed.
sumanah wrote:
Aravind, thanks for looking into this! Marking it WORKSFORME, which is to say, there does not seem to be a problem now (maybe it got fixed in the last 18 months). Please do feel free to pick up another bug to look into!
Current version at https://git.wikimedia.org/blame/mediawiki%2Fextensions%2FAccessControl/HEAD/AccessControl.i18n.php has less strings and a "FIXME" removed, compared to https://git.wikimedia.org/blame/mediawiki%2Fextensions%2FAccessControl/34ca5a5542f273983a74591fb23d673906755d9c/AccessControl.i18n.php , so indeed this seems to have been fixed.
kapica wrote:
These messages were a relic from an earlier version of the extension. In version > 2 never been used.