Page MenuHomePhabricator

<s>Add</s> Remove monument_random field + index to the monuments_all table
Closed, ResolvedPublic


Field should get a random number on inserting a row

Version: unspecified
Severity: normal

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 12:29 AM
bzimport set Reference to bz37974.
bzimport added a subscriber: Unknown Object (MLST).

Not sure if I'm happy with . This kills performance. Reopened so I don't forget about this. The random should be done on REPLACE. Now all the entries are updated causing index updates.

Pff, this didn't work as all as intended. We should probably just get rid of it alltogether.

Could someone either add more details or close this?

In the monuments_all table we have monument_random mediumint(8) unsigned DEFAULT NULL, and KEY monument_random (monument_random),

Everything that relies on that should be updated and this should be removed.

Change 286149 had a related patch set uploaded (by Lokal Profil):
[NOT TESTED] Remove monument_random from database and api.

When deployed the kml output should be checked (in addition to ensuring the whole thing still works)

Change 286149 merged by jenkins-bot:
[NOT TESTED] Remove monument_random from database and api.

Mentioned in SAL [2016-05-06T18:42:50Z] <Lokal_Profil> Deployed latest from Git, 2d3ee40 (T39974), 766d814, e2fac07 and d2c242a (T39422)

Lokal_Profil closed this task as Resolved.EditedMay 6 2016, 8:08 PM

Ahm... so when I check this kml it is empty... but a quick revert shows that that was the case even before So I'll close this as resolved and instead open another for the empty kml.

edit: It is all fine. Just me being tired and expecting linebreaks throughout or not at all