Field should get a random number on inserting a row
Version: unspecified
Severity: normal
Description
Description
Details
Details
- Reference
- bz37974
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| [NOT TESTED] Remove monument_random from database and api. | labs/tools/heritage | master | +1 -13 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T55807 Monuments database future (tracking) | |||
| Resolved | None | T39975 Sort KML output by monument_random field | |||
| Resolved | Lokal_Profil | T39974 <s>Add</s> Remove monument_random field + index to the monuments_all table |
Event Timeline
Comment Actions
Not sure if I'm happy with https://fisheye.toolserver.org/browse/erfgoed/erfgoedbot/sql/fill_table_monuments_all.sql?r1=736&r2=737 . This kills performance. Reopened so I don't forget about this. The random should be done on REPLACE. Now all the entries are updated causing index updates.
Comment Actions
Pff, this didn't work as all as intended. We should probably just get rid of it alltogether.
Comment Actions
In the monuments_all table we have monument_random mediumint(8) unsigned DEFAULT NULL, and KEY monument_random (monument_random),
Everything that relies on that should be updated and this should be removed.
Comment Actions
Change 286149 had a related patch set uploaded (by Lokal Profil):
[NOT TESTED] Remove monument_random from database and api.
Comment Actions
When deployed the kml output should be checked (in addition to ensuring the whole thing still works)
Comment Actions
Change 286149 merged by jenkins-bot:
[NOT TESTED] Remove monument_random from database and api.
Comment Actions
Ahm... so when I check this kml it is empty... but a quick revert shows that that was the case even before https://gerrit.wikimedia.org/r/286149 So I'll close this as resolved and instead open another for the empty kml.
edit: It is all fine. Just me being tired and expecting linebreaks throughout or not at all