Page MenuHomePhabricator

Link to FeedBack dashboard not localized in MoodBar confirmation screen
Closed, ResolvedPublic

Description

Author: gciampaglia

Description:
The link to the Feedback dashboard that MoodBar shows after posting an item of feedback seems to be hardcoded to Special:FeedbackDashboard on enwiki.

To replicate:

  1. Log into nlwiki*
  2. Open MoodBar and post a message
  3. Wait for the window to redraw with the confirmation message
  4. Click on the link in the confirmation, it should point to Special:FeedbackDashboard on enwiki, instead of nlwiki
  • or any other wiki that has MoodBar enabled so far. See following list: 'testwiki' => true, 'enwiki' => true, 'frwikisource' => true, bug 34618 'incubatorwiki' => true, bug 32417 'nlwiki' => true, bug 32202 'sewikimedia' => true, bug 32757

Version: unspecified
Severity: normal

Details

Reference
bz39612

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 1:06 AM
bzimport set Reference to bz39612.
bzimport added a subscriber: Unknown Object (MLST).

Wikimedia Site Configuration issue, it's hardcoded to enwiki -.-

From CommonSettings.php:
$wgMoodBarConfig['feedbackDashboardUrl'] = '//en.wikipedia.org/wiki/Special:FeedbackDashboard';

I'm not even sure this should be changed in the WMF config... Shouldn't the extension just use something like SpecialPage::getTitleFor( 'FeedbackDashboard' )->getFullURL()?

(In reply to comment #2)

I'm not even sure this should be changed in the WMF config... Shouldn't the
extension just use something like SpecialPage::getTitleFor(
'FeedbackDashboard'
)->getFullURL()?

Moving to extension.

(In reply to comment #2)

I'm not even sure this should be changed in the WMF config... Shouldn't the
extension just use something like SpecialPage::getTitleFor(
'FeedbackDashboard'
)->getFullURL()?

This was done in Gerrit change 37682

(In reply to comment #4)

This was done in Gerrit change #37682

Merged, consider this fixed?