Page MenuHomePhabricator

Add user contribution links to existing user conflicts
Closed, DeclinedPublic

Description

Author: swalling

Description:
Error screenshot

See the attached file.

It looks like there is some error output which is broken. When you attempt to create a username that is too close to an existing username (e.g. one character different) the error shows the associated user and links to their contribs. The contributions link is currently broken.


Version: unspecified
Severity: enhancement

Attached:

Details

Reference
bz40576

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 12:46 AM
bzimport added projects: AntiSpoof, I18n.
bzimport set Reference to bz40576.
bzimport added a subscriber: Unknown Object (MLST).
Reedy added a comment.Sep 27 2012, 6:13 PM

'antispoof-conflict-top' => 'The name "$1" is too similar to {{PLURAL:$2|the existing account|the following $2 accounts}}:',

$message = wfMessage( 'antispoof-conflict-top', $name )->numParams( $numConflicts )->escaped();

I'm guessing the message functions are called wrongly..

Siebrands fault from https://gerrit.wikimedia.org/r/#/c/22363/

Reedy added a comment.Sep 27 2012, 6:18 PM

Errr, I retract that, slightly.

'antispoof-conflict-item' => '$1', # do not translate or duplicate this message to other languages

$message .= '<ul>';
foreach ( $conflicts as $simUser ) {
$message .= '<li>' . wfMessage( 'antispoof-conflict-item', $simUser )->escaped() . '</li>';
}

Mix of Siebrands change, and the enwiki customisation of said message

https://en.wikipedia.org/w/index.php?title=MediaWiki:Antispoof-conflict-item&action=edit

$1 (<a href="/w/index.php?title=Special:Contributions&target=$1">contribs</a>)

'antispoof-conflict-item' => '$1', # do not translate or duplicate this message to other languages

Probably makes most sense to fix this message upstream, and change the code to support the desired output. Maybe.

Reedy added a comment.Sep 27 2012, 7:09 PM

$message .= '<li>' . wfMsg( 'antispoof-conflict-item
', $simUser ) . '</li>';
$message .= '<li>' . wfMessage( 'antispoof-conflict-
item', $simUser )->escaped() . '</li>';

Technically, this isn't actually a bug... And should probably be swapped to a feature request to have the contribution links...

swalling wrote:

(In reply to comment #3)

$message .= '<li>' . wfMsg( 'antispoof-conflict-item
', $simUser ) . '</li>';
$message .= '<li>' . wfMessage( 'antispoof-conflict-
item', $simUser )->escaped() . '</li>';

Technically, this isn't actually a bug... And should probably be swapped to a
feature request to have the contribution links...

IMO, I don't think the contribution links provide clear value. The message just needs to tell the user that a similar name already exists, not tell them what the person has done.

kolbert closed this task as Declined.Nov 23 2019, 6:59 PM
kolbert added a subscriber: kolbert.

Declining in favour of T209669, as the error output is no longer broken and that task seems like a more updated proposal.