Page MenuHomePhabricator

Protect/unprotect do not verify if the page is already protected/unprotected
Closed, ResolvedPublic

Description

Author: cevo_deguix

Description:
I use robots to do jobs like protecting/unprotecting pages easier. Sometimes I
want to protect or unprotect some pages as a whole, and those pages can be
either protected or unprotected.

I found out that the wiki doesn't warn me when I try to protect a page already
protected. Also, the wiki adds the action to the protection log even if the page
was already protected before.

I can reproduce it when accessing the page with "&action=protect" on a page
already protected (or "&action=unprotect" on a page unprotected). If I confirm
the operation, it goes directly back to the article (no action successful page
or anything) and logs the action to the protection log.


Version: 1.4.x
Severity: minor

Details

Reference
bz2261

Event Timeline

bzimport raised the priority of this task from to Lowest.Nov 21 2014, 8:31 PM
bzimport set Reference to bz2261.
bzimport added a subscriber: Unknown Object (MLST).

wegge wrote:

Why is this a problem? The page does not change protection status by being
protected one more time.

cevo_deguix wrote:

Protecting one more time makes the status to appear on the protection log one
more time.

Fixed in HEAD, will be in 1.6.

Now show the article instead of showing again the (un)?protect box.