Page MenuHomePhabricator

mw.util.addPortletLink doesn't work for third party skins that have different portlet HTML
Closed, DeclinedPublic


As the title says.

Version: unspecified
Severity: minor



Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 1:03 AM
bzimport set Reference to bz40813.
bzimport added a subscriber: Unknown Object (MLST).

Should it?

The only thing addPortletLink needs to work properly is an <ul> inside the portlet element (and it still sort of works if that's missing). This is a pretty reasonable expectation and the usual convention for menus all over the Internet. Maybe it should support the portlet being an <ul> by itself - and that should be it.

There is a very minimal HTML requirement for skins to make this work. Adding hooks for these or other abstractions is unnecessary.

Note that it is already supported to not have any portlets (such as in Minerva), in which case addPortletLink() does not cause an error.