Page MenuHomePhabricator

File description page not accessible inside <gallery>
Closed, ResolvedPublic

Description

screenshot

Inside a <gallery> it is impossible to go to the file description page:

  1. Click on the gallery thumbnail. TMH opens a window.
  2. Click on "Menu"
  3. Try to click on the title. It is a link but without any reaction

It works well with standard [[File:foo.ogv|thumb|...]] embedding.


Version: master
Severity: normal
URL: https://test2.wikipedia.org/wiki/User:JanGerber/sandbox#Gallery

Attached:

TMH_gallery.png (690×1 px, 227 KB)

Details

Reference
bz41762

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 1:12 AM
bzimport set Reference to bz41762.

This is due to the overlay that is set by ui.dialog
Basically this part blocks the click handling of the <a>

$(document).bind($.ui.dialog.overlay.events, function(event) {

// stop events if the z-index of the target is < the z-index of the overlay
// we cannot return true when we don't want to cancel the event (#3523)
if ($(event.target).zIndex() < $.ui.dialog.overlay.maxZ) {
     return false;
}

});

What if we move

the div.overlay-win k-menu ui-widget-content with the controls, below the videoHolder and below the timed text, and remove the z-index from from the settings div. It will then naturally be positioned on top of the video. Which is always better than mucking about with the z-index.

mdale wrote:

Thanks for the pointer Derk-Jan Hartman,

Fixed in https://gerrit.wikimedia.org/r/31741

Gilles triaged this task as Unbreak Now! priority.Dec 4 2014, 10:10 AM
Gilles moved this task from Untriaged to Done on the Multimedia board.
Gilles lowered the priority of this task from Unbreak Now! to Needs Triage.Dec 4 2014, 11:22 AM