Page MenuHomePhabricator

ApiRemoveClaims needs to report new revision ID on success
Closed, ResolvedPublic

Description

ApiRemoveClaims does not include the new revision ID in the API result. The problem is that ApiRemoveClaims operates on a list of claim IDs, which may belong to multiple entities - so there is no obvious way to include the new revision IDs.

Also, ApiRemoveClaims takes a single baserevisionid as a parameter. This will not work with claims that belong to a different Entity.

Should probably be restricted to operating on claims of a single entity; for clarity, the entities ID should probably be required as a parameter. This way, supplying a baserevisionid and receiving back a new revision ID will work like for other API modules.

There does not seem to be much value in supporting the removal of claims from different entities at once.


Version: unspecified
Severity: normal

Details

Reference
bz45275

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 1:17 AM
bzimport set Reference to bz45275.
bzimport added a subscriber: Unknown Object (MLST).

Adam, is this still a problem?