Page MenuHomePhabricator
Create Task
Maniphest T48444

Bugzilla: Comment parser for gerrit Change-Id should not ignore opening parenthesis
Closed, ResolvedPublic
Actions

Description

In bug 46434 comment 1 I said:

November (Ic55d539b9a58f448b5 / I9d2b148e57b).

The first one is not linked, the second one is.

Version: wmf-deployment
Severity: minor

Details

Reference
bz46444

Event Timeline

• bzimport raised the priority of this task from to Low.Nov 22 2014, 1:39 AM
• bzimport added a project: Wikimedia-Bugzilla.
• bzimport set Reference to bz46444.
Krinkle created this task.Mar 22 2013, 1:56 AM
Aklapper added a comment.Mar 22 2013, 10:55 AM

Whoever wants to write a patch, the regex is here:
https://gerrit.wikimedia.org/r/gitweb?p=wikimedia/bugzilla/modifications.git;a=blob;f=bugzilla-4.2/extensions/Wikimedia/Extension.pm#l61

matmarex added a comment.Mar 25 2013, 6:25 PM

Taking this: Iaf696342.

Aklapper added a comment.Mar 27 2013, 11:53 AM

Patch tested in my local Bugzilla (we miss a Labs instance for testing) and works fine, +2. Note that merging a commit in Gerrit does not mean that it goes live (we miss puppet), so another RT ticket is required for getting that deployed once it's merged in Gerrit...

matmarex added a comment.Mar 31 2013, 8:43 PM

How's the RT ticket part going?

Aklapper added a comment.Apr 2 2013, 10:25 AM

Sorry, fell of the list for last week. Now requested as RT #4867.

Aklapper added a comment.Apr 2 2013, 5:37 PM

This is deployed now, see bug 46444 comment 0 for testcase.

Thanks to andrewbogott for deploying.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL