Page MenuHomePhabricator
Create Task
Maniphest T49339

beta cluster: wrong MessagesEn.php file?
Closed, ResolvedPublic
Actions

Description

wrong string on failed login on beta

Attempt to login with a an incorrect username. Error message contains the string "User names are case sensitive". However, the string should be "Usernames are case sensitive". (No space between "User" and "names")

Line 1129 of the file at @deployment-bastion:/usr/local/apache/common/php-master/languages/messages/MessagesEn.php seems to be the correct Messages file and contains the correct string, but that string does not show up in the login attempt on beta. See screen shot.

Version: unspecified
Severity: normal

Attached:

login_wrong_string.png (541×728 px, 42 KB)

Details

Reference
bz47339

Event Timeline

• bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 1:15 AM
• bzimport added projects: Beta-Cluster-Infrastructure, Browser-test-bug.
• bzimport set Reference to bz47339.
• bzimport added a subscriber: Unknown Object (MLST).
• Cmcmahon created this task.Apr 17 2013, 10:21 PM
zeljkofilipin added a comment.Apr 18 2013, 12:29 PM

Test results:

en.wikipedia.beta.wmflabs.org, 3/6 tests failed

https://wmf.ci.cloudbees.com/job/_debug-browsertests-template/110/testReport/(root)/Log%20in/

test2.wikipedia.org, no failures

https://wmf.ci.cloudbees.com/job/_debug-browsertests-template/111/testReport/(root)/Log%20in/

en.wikipedia.org, 3/6 tests failed

https://wmf.ci.cloudbees.com/job/_debug-browsertests-template/112/testReport/(root)/Log%20in/

Both en.wikipedia.beta.wmflabs.org and en.wikipedia.org have 3 failed tests, but 2 test failures are the same, 1 is different.

zeljkofilipin added a comment.Apr 18 2013, 12:34 PM

Both en.wikipedia.beta.wmflabs.org and en.wikipedia.org have "user name", only test2.wikipedia.org has "username". It would probably be better to change test2.wikipedia.org to behave like other sites.

zeljkofilipin added a comment.Apr 18 2013, 12:57 PM

The test is checking the feedback error message after trying to log in with incorrect username. Is there a reason for different feedback messages when user provides incorrect username? (See attached login.png.)

zeljkofilipin added a comment.Apr 18 2013, 1:00 PM

Created attachment 12135
Difference in feedback messages

Attached:

login.png (900×1 px, 341 KB)

zeljkofilipin added a comment.Apr 18 2013, 1:11 PM

Similar problem happens when user tries to log in without entering any credentials: en.wikipedia.beta.wmflabs.org and en.wikipedia.org have "user name",
test2.wikipedia.org has "username". See attached screen shot.

zeljkofilipin added a comment.Apr 18 2013, 1:12 PM

Created attachment 12137
username or user name

Attached:

username.png (900×1 px, 338 KB)

Reedy added a comment.Apr 18 2013, 1:15 PM

http://en.wikipedia.beta.wmflabs.org/w/index.php?title=MediaWiki:Nosuchusershort&action=history

^ Local customi[zs]ations. Which makes this bug... invalid?

zeljkofilipin added a comment.Apr 18 2013, 1:16 PM

And similar problem when user tries to log in without entering password, en.wikipedia.org has different feedback message than other sites. See attached screen shot.

zeljkofilipin added a comment.Apr 18 2013, 1:17 PM

Created attachment 12138
password

Attached:

password.png (900×1 px, 351 KB)

• Cmcmahon added a comment.Apr 18 2013, 4:38 PM

Edited

http://en.wikipedia.beta.wmflabs.org/wiki/MediaWiki:Nosuchuser and
http://test2.wikipedia.org/wiki/MediaWiki:Nosuchuser

to match

http://en.wikipedia.org/wiki/MediaWiki:Nosuchuser

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL