Page MenuHomePhabricator

Missing check box in Echo preferences
Closed, ResolvedPublic

Description

Author: lwelling

Description:
Screenshot of echo preferences

See screenshot

There is no checkbox for web notification of talk page messages.

I know that is because we consider them more important and therefore cannot be disabled. The box being missing though implies to me that they don't exist.

Can we add a checked, but disabled checkbox to explicitly show that it is compulsory?


Version: unspecified
Severity: normal
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=46550

Attached:

Details

Reference
bz47743

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 1:44 AM
bzimport added a project: Notifications.
bzimport set Reference to bz47743.
bzimport created this task.Apr 26 2013, 6:40 PM

We could, but it would introduce some complications. If there is a disabled checkbox, it means that someone could theoretically submit it unchecked (via Firebug or API). We would need to make sure there are validation checks for the disabled items in the Preferences class. Also right now there is no way to generate disabled checkboxes from a checkmatrix in HTMLForm, but that could be added.

Related URL: https://gerrit.wikimedia.org/r/61163 (Gerrit Change I61a6b2bcce3102e2350088912ee77620a9f678f9)

Related URL: https://gerrit.wikimedia.org/r/61509 (Gerrit Change I9284a2ad29de654062e54a78a76c10dd49c35ed7)

lwelling wrote:

*** Bug 48031 has been marked as a duplicate of this bug. ***

Related URL: https://gerrit.wikimedia.org/r/64835 (Gerrit Change I61a6b2bcce3102e2350088912ee77620a9f678f9)

This has been merged and deployed to en.wiki. Instead of missing checkboxes there are now grayed unchangable boxes.