Page MenuHomePhabricator

Special:Statistics - content language takes precedence over user language
Closed, ResolvedPublic

Description

Special:Statistics utilises the content language and not the user language in case an extension adds information to it.

This issue emerged during the problem investigation on 48537. A fix was proposed for core to resolve this (48537#c2).


Version: 1.22.0
Severity: normal

Details

Reference
bz48542

Event Timeline

bzimport raised the priority of this task from to Normal.Nov 22 2014, 1:41 AM
bzimport set Reference to bz48542.
Kghbln created this task.May 16 2013, 3:20 PM

Adding further information: keywords, target milestone (little wish), assigned to and changing importance to normal normal

Unknown Object (User) added a comment.May 16 2013, 3:34 PM

The required change:

SpecialStatistics/line 301 from

$name = $this->msg( $key )->inContentLanguage()->parse();

to

$name = $this->msg( $key )->parse();

No 1.21.0 material as release is imminent.

Fair enough though I had hoped that somehow moving a fix into the 1.21 branch might be within the range of possibility even after the first release.

Related URL: https://gerrit.wikimedia.org/r/64087 (Gerrit Change Ib7d9cb5aa3051b5d602f7a0838425d92fc7a515f)

Unknown Object (User) added a comment.May 16 2013, 4:55 PM

Andre, could you assign a reviewer for the patch (last time it took 5 month).

(In reply to comment #6)

Andre, could you assign a reviewer for the patch (last time it took 5 month).

I just reviewed your patch (It is after all a 1 line fix).


Marking this bug as fixed. In regards to backporting the fix - personally I don't think the issue is severe enough to warrant backporting. However if you feel strongly it should be, maybe run it by hexmode to see if he thinks it should be backported.

It is a one line fix. I don't have a problem adding this before release and it will help some users.

So that I can do this quickly, someone needs to provide a gerrit change with an update to the release notes that will make it so that I only have to verify the change to have it merged.

Related URL: https://gerrit.wikimedia.org/r/64112 (Gerrit Change Ib7d9cb5aa3051b5d602f7a0838425d92fc7a515f)

Just wanted to say that all of you are awesome. Thank you for dealing with this!