Page MenuHomePhabricator

E-mail addresses are getting double-escaped
Closed, ResolvedPublic

Description

In both the "Add Reviewer" box and the search box with "owner:..." - you now get "Taha<wikitaha@gmail.com>" which is a bit ugly. Some upstream change?


Version: unspecified
Severity: normal
See Also:
http://code.google.com/p/gerrit/issues/detail?id=1574

Details

Reference
bz48979

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 1:43 AM
bzimport added projects: Gerrit, Upstream.
bzimport set Reference to bz48979.
bzimport added a subscriber: Unknown Object (MLST).

For the "Add Reviewer" box, I can reproduce the problem only for the letter
"T" (without quotes, regardless of case). If I go on typing for example "Ta",
the problem disappears. Other single letter values work without problems in
the "Add Reviewer" box.

Same for the search box. "owner:T" allows to exhibit the problem, while
"owner:Ta" does not. Neither do other single letter owners, as "owner:Q".

The problem also occurs for the other search predicates as for example reviewer.

Wasn't this fixed upstream? Or reported? I could've sworn we've had this discussion before.

David recalled that it was reported upstream half a year ago

https://code.google.com/p/gerrit/issues/detail?id=1574

, but the fix is rather fresh :-) still waiting for review

https://gerrit-review.googlesource.com/#/c/46370/

. I'll push it to our branch once I got some feedback on it.

Fix got accepted upstream, submitting for our local branch

Related URL: https://gerrit.wikimedia.org/r/66387 (Gerrit Change Ifc0b4f4d52a2b2a5a6a511b943a11d752c186c39)

Should be fixed since we upgraded gerrit on 2013-06-27.