Page MenuHomePhabricator

Have a different link for page patrol and revision patrol
Closed, ResolvedPublic

Description

Currently [Mark this page as patrolled] is shown for both revision patrol and new page patrol. I think it should be changed to [Mark this revision as patrolled] or [Mark this page as patrolled] depending on if the entry is first revision of page or not. This would clarify to the user if they are doing a new page patrol or a revision patrol.


Version: 1.22.0
Severity: major
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=48928

Details

Reference
bz49115

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 1:46 AM
bzimport set Reference to bz49115.
bzimport added a subscriber: Unknown Object (MLST).

This is a rather important bug because people will be patrolling revisions they've not even looked at thinking they're still patrolling pages as they used to.

Related URL: https://gerrit.wikimedia.org/r/67040 (Gerrit Change Ib4d72179e4029f0c089c3147bdf4bd6daac0374e)

romaine.wiki wrote:

There are two types of [Mark this page as patrolled]: the ones for new articles, and the one for other revisions. On the Dutch Wikipedia we only show the [Mark this page as patrolled] for new pages at the bottom of pages. The mark als patrolled for other revisions is only shown on the diff pages.

(In reply to comment #3)

There are two types of [Mark this page as patrolled]: the ones for new
articles, and the one for other revisions. On the Dutch Wikipedia we only
show
the [Mark this page as patrolled] for new pages at the bottom of pages. The
mark als patrolled for other revisions is only shown on the diff pages.

Is that something the Dutch Wikipedia changes? I thought this is the default (firs t revision links for page patrol are shown on the bottom, edit patrol links are shown in diff mode).

(In reply to comment #4)

(In reply to comment #3)

There are two types of [Mark this page as patrolled]: the ones for new
articles, and the one for other revisions. On the Dutch Wikipedia we only
show
the [Mark this page as patrolled] for new pages at the bottom of pages. The
mark als patrolled for other revisions is only shown on the diff pages.

Is that something the Dutch Wikipedia changes? I thought this is the default
(firs t revision links for page patrol are shown on the bottom, edit patrol
links are shown in diff mode).

This is the way it used to be. It was recently changed. Based on comments in irc, Romaine views this as a bad change, and wants the old behaviour back.

romaine.wiki wrote:

What I described is how it was and still is supposed to be. The way it worked was exactly suitable for the way the users of the Dutch Wikipedia work with this system for many many years. Also all other wiki's I know that use the patrol extension do use this exactly the same way, like for example nl Wikivoyage. This isn't Flagged Revisions to mark a page and the last version will be shown. The patrol system is to check all individual edits and not to mark recent pages. With a mark as patrolled at the bottom of every page if unchecked last edits, the way of working with this extension breaks! Users start now clicking on the link without checking anything, purely because they see the link at the bottom of pages.

A side effect is also that the link breaks massively with the design of articles as an annoying bar is shown between the categories bar and the other bare above, they are designed to fit there perfectly.

Please fix this problem as fast as possible, this is a big problem for wiki's now.

The root cause for this bug was fixed with https://gerrit.wikimedia.org/r/67040 so that this is no longer an issue.