Page MenuHomePhabricator

Dropping rc_moved_to_title/rc_moved_to_ns on wmf databases
Closed, ResolvedPublic

Description

Schema Change:

All wikis
tables: recentchanges
changes: Dropping rc_moved_to_title
status: merged
Table recentchanges contains rc_moved_to_title field. Dropping...

gerrit change I68e8c0bb

Version: unspecified
Severity: minor

ALTER to run: ALTER TABLE /*$wgDBprefix*/recentchanges DROP COLUMN rc_moved_to_ns, DROP COLUMN rc_moved_to_title;

Progress:

s1

  • eqiad
  • codfw

s2

s3

s4

s5

s6

s7

s8

wikitech

  • eqiad
  • codfw

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 1:51 AM
bzimport set Reference to bz49191.

Hello Umherirrender: This code change is merged (https://gerrit.wikimedia.org/r/#/c/17894/) so is this now done? (this bug was a blind copy/paste from the Schema change page on wikitech from the "to be scheduled" section.)

The patch to remove the two fields from master is already merged, that is correct, but I did not known, if someone drops the columns also from wmf sites and if that should be done.

When a nullable column or a column with a default value is not dropped from production, that does not hurt, because a insert will use the default value and than the SQL is still valid/correct.

Krenair added a subscriber: Krenair.

Probably done? Needs checking. Otherwise, adding the Blocked-on-schema-change.

Change 450934 had a related patch set uploaded (by Marostegui; owner: Marostegui):
[operations/puppet@production] filtered_tables: Remove unused columns

https://gerrit.wikimedia.org/r/450934

I have removed the column from db2075 (codfw - s5) and I am going to leave it like that for a few days, to make sure nothing writes to that column. If that happens replication will break and we'll know.

  • labsdb1011
  • labsdb1010
  • labsdb1009
  • dbstore2001
  • dbstore1002
  • db2094
  • db2089
  • db2084
  • db2075 T51191#4483973
  • db2066
  • db2059
  • db2052
  • db2038
  • db1124
  • db1113
  • db1110
  • db1102
  • db1100
  • db1097
  • db1096
  • db1082
  • db1070

s6 eqiad progress

  • labsdb1011
  • labsdb1010
  • labsdb1009
  • dbstore1002
  • db1125
  • db1113
  • db1098
  • db1096
  • db1093
  • db1088
  • db1085
  • db1061

s2 eqiad progress

  • labsdb1011
  • labsdb1010
  • labsdb1009
  • dbstore1002
  • db1125
  • db1122
  • db1105
  • db1103
  • db1095
  • db1090
  • db1076
  • db1074
  • db1066

s8 eqiad progress

  • labsdb1011
  • labsdb1010
  • labsdb1009
  • dbstore1002
  • db1124
  • db1109
  • db1104
  • db1101
  • db1099
  • db1092
  • db1087
  • db1071

s4 eqiad progress

  • labsdb1011
  • labsdb1010
  • labsdb1009
  • dbstore1002
  • db1125
  • db1121
  • db1103
  • db1102
  • db1097
  • db1091
  • db1084
  • db1081
  • db1068

Mentioned in SAL (#wikimedia-operations) [2018-08-29T05:55:26Z] <marostegui> Deploy schema change on db1073 (labswiki) - T114117 T51191 T67448

s7 eqiad progress

  • labsdb1011
  • labsdb1010
  • labsdb1009
  • dbstore1002
  • db1125
  • db1101
  • db1098
  • db1094
  • db1090
  • db1086
  • db1079
  • db1062

s3 eqiad progress

  • labsdb1011
  • labsdb1010
  • labsdb1009
  • dbstore1002
  • db1124
  • db1123
  • db1095
  • db1078
  • db1077
  • db1075

Change 450934 merged by Marostegui:
[operations/puppet@production] filtered_tables: Remove unused columns

https://gerrit.wikimedia.org/r/450934

Mentioned in SAL (#wikimedia-operations) [2018-09-14T07:49:20Z] <marostegui> Deploy schema change on s4 eqiad master (db1068) - T67448 T114117 T51191

Mentioned in SAL (#wikimedia-operations) [2018-09-17T05:28:00Z] <marostegui> Deploy schema change on s1 eqiad master (db1067) - T67448 T114117 T51191

Marostegui changed the task status from Open to Stalled.Oct 24 2018, 9:55 AM
Marostegui moved this task from In progress to Pending comment on the DBA board.
Marostegui changed the task status from Stalled to Open.Nov 12 2018, 9:08 AM

Mentioned in SAL (#wikimedia-operations) [2018-11-12T10:45:18Z] <marostegui> Deploy schema change on db2048 (s1 codfw master), this will generate lag on s1 codfw - T51191

Marostegui updated the task description. (Show Details)