Page MenuHomePhabricator
Create Task
Maniphest T51191

Dropping rc_moved_to_title/rc_moved_to_ns on wmf databases
Closed, ResolvedPublic
Actions

Description

Schema Change:

All wikis
tables: recentchanges
changes: Dropping rc_moved_to_title
status: merged
Table recentchanges contains rc_moved_to_title field. Dropping...

gerrit change I68e8c0bb

Version: unspecified
Severity: minor

ALTER to run: ALTER TABLE /*$wgDBprefix*/recentchanges DROP COLUMN rc_moved_to_ns, DROP COLUMN rc_moved_to_title;

Progress:

s1

  • eqiad
  • codfw

s2

s3

s4

s5

s6

s7

s8

wikitech

  • eqiad
  • codfw

Details

Reference
bz49191
SubjectRepoBranchLines +/-
filtered_tables: Remove unused columnsoperations/puppetproduction+0 -3
Customize query in gerrit

Related Objects

Event Timeline

• bzimport raised the priority of this task from to Low.Nov 22 2014, 1:51 AM
• bzimport added a project: WMF-General-or-Unknown.
• bzimport set Reference to bz49191.
greg created this task.Jun 5 2013, 5:06 PM
greg added a comment.Jun 8 2013, 8:30 PM

Hello Umherirrender: This code change is merged (https://gerrit.wikimedia.org/r/#/c/17894/) so is this now done? (this bug was a blind copy/paste from the Schema change page on wikitech from the "to be scheduled" section.)

Umherirrender added a comment.Jun 9 2013, 9:15 AM

The patch to remove the two fields from master is already merged, that is correct, but I did not known, if someone drops the columns also from wmf sites and if that should be done.

When a nullable column or a column with a default value is not dropped from production, that does not hurt, because a insert will use the default value and than the SQL is still valid/correct.

Umherirrender added a project: Schema-change.May 11 2015, 7:08 PM
Krenair removed • Springle as the assignee of this task.Oct 4 2015, 2:52 AM
Krenair subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 4 2015, 2:52 AM
Umherirrender unsubscribed.Nov 1 2015, 6:19 PM
Nemo_bis edited projects, added DBA; removed WMF-General-or-Unknown.Dec 5 2015, 2:17 PM
Danny_B moved this task from Unsorted to Delete / Drop / Remove on the Schema-change board.Apr 29 2016, 10:22 PM
jcrespo subscribed.Apr 20 2017, 1:41 PM

Probably done? Needs checking. Otherwise, adding the Schema-change-in-production.

jcrespo removed a parent task: T51188: [DO NOT USE] Schema changes for Wikimedia wikis (tracking) [superseded by #Blocked-on-schema-change].Apr 20 2017, 1:41 PM
Umherirrender added a project: Schema-change-in-production.Apr 28 2017, 2:56 PM
jcrespo removed a project: Schema-change-in-production.Apr 28 2017, 3:12 PM
jcrespo added a parent task: T54921: Database tables to be dropped on Wikimedia wikis and other WMF databases (tracking).
jcrespo added a project: Schema-change-in-production.

Sorry, I was wrong on my latest edit, this is an index drop.

jcrespo removed a parent task: T54921: Database tables to be dropped on Wikimedia wikis and other WMF databases (tracking).Apr 28 2017, 3:13 PM
Umherirrender mentioned this in T104459: Detect object, schema and data drifts between mediawiki HEAD, production masters and replicas.Jul 10 2018, 7:39 PM
Marostegui moved this task from Triage to Pending comment on the DBA board.Jul 11 2018, 3:03 PM
Marostegui claimed this task.Aug 7 2018, 8:09 AM
Marostegui updated the task description. (Show Details)Aug 7 2018, 8:38 AM
Marostegui moved this task from Pending comment to In progress on the DBA board.Aug 7 2018, 8:43 AM
Marostegui moved this task from Backlog to In progress on the Schema-change-in-production board.
Marostegui updated the task description. (Show Details)Aug 7 2018, 10:05 AM
gerritbot subscribed.Aug 7 2018, 10:10 AM

Change 450934 had a related patch set uploaded (by Marostegui; owner: Marostegui):
[operations/puppet@production] filtered_tables: Remove unused columns

https://gerrit.wikimedia.org/r/450934

gerritbot added a project: Patch-For-Review.Aug 7 2018, 10:10 AM
Marostegui updated the task description. (Show Details)Aug 7 2018, 10:13 AM
Marostegui added a comment.Aug 7 2018, 10:19 AM

I have removed the column from db2075 (codfw - s5) and I am going to leave it like that for a few days, to make sure nothing writes to that column. If that happens replication will break and we'll know.

Marostegui added a comment.EditedAug 20 2018, 8:36 AM
  • labsdb1011
  • labsdb1010
  • labsdb1009
  • dbstore2001
  • dbstore1002
  • db2094
  • db2089
  • db2084
  • db2075 T51191#4483973
  • db2066
  • db2059
  • db2052
  • db2038
  • db1124
  • db1113
  • db1110
  • db1102
  • db1100
  • db1097
  • db1096
  • db1082
  • db1070
Stashbot mentioned this in T67448: Dropping rc_cur_time on wmf databases.Aug 22 2018, 12:15 PM
Stashbot mentioned this in T114117: Drop externallinks.el_from_namespace on wmf databases.
Stashbot subscribed.

Mentioned in SAL (#wikimedia-operations) [2018-08-22T12:15:37Z] <marostegui> Deploy schema change on db1070 (s5 primary master) - T67448 T114117 T51191

Marostegui updated the task description. (Show Details)Aug 22 2018, 12:54 PM
Marostegui updated the task description. (Show Details)EditedAug 22 2018, 2:21 PM

s6 eqiad progress

  • labsdb1011
  • labsdb1010
  • labsdb1009
  • dbstore1002
  • db1125
  • db1113
  • db1098
  • db1096
  • db1093
  • db1088
  • db1085
  • db1061
Marostegui updated the task description. (Show Details)Aug 23 2018, 4:46 AM
Marostegui updated the task description. (Show Details)Aug 23 2018, 10:55 AM
Marostegui added a comment.EditedAug 23 2018, 11:02 AM

s2 eqiad progress

  • labsdb1011
  • labsdb1010
  • labsdb1009
  • dbstore1002
  • db1125
  • db1122
  • db1105
  • db1103
  • db1095
  • db1090
  • db1076
  • db1074
  • db1066
Marostegui updated the task description. (Show Details)Aug 23 2018, 11:59 AM
Marostegui updated the task description. (Show Details)EditedAug 24 2018, 3:05 PM

s8 eqiad progress

  • labsdb1011
  • labsdb1010
  • labsdb1009
  • dbstore1002
  • db1124
  • db1109
  • db1104
  • db1101
  • db1099
  • db1092
  • db1087
  • db1071
Marostegui updated the task description. (Show Details)Aug 24 2018, 3:08 PM
Marostegui updated the task description. (Show Details)Aug 27 2018, 6:23 AM
Marostegui added a comment.EditedAug 28 2018, 5:05 AM

s4 eqiad progress

  • labsdb1011
  • labsdb1010
  • labsdb1009
  • dbstore1002
  • db1125
  • db1121
  • db1103
  • db1102
  • db1097
  • db1091
  • db1084
  • db1081
  • db1068
Marostegui updated the task description. (Show Details)Aug 28 2018, 5:05 AM
Marostegui updated the task description. (Show Details)Aug 28 2018, 7:43 AM
Stashbot added a comment.Aug 29 2018, 5:55 AM

Mentioned in SAL (#wikimedia-operations) [2018-08-29T05:55:26Z] <marostegui> Deploy schema change on db1073 (labswiki) - T114117 T51191 T67448

Marostegui updated the task description. (Show Details)Aug 29 2018, 5:56 AM
Marostegui added a comment.EditedSep 3 2018, 1:19 PM

s7 eqiad progress

  • labsdb1011
  • labsdb1010
  • labsdb1009
  • dbstore1002
  • db1125
  • db1101
  • db1098
  • db1094
  • db1090
  • db1086
  • db1079
  • db1062
Marostegui updated the task description. (Show Details)Sep 3 2018, 1:26 PM
Marostegui updated the task description. (Show Details)EditedSep 4 2018, 12:40 PM

s3 eqiad progress

  • labsdb1011
  • labsdb1010
  • labsdb1009
  • dbstore1002
  • db1124
  • db1123
  • db1095
  • db1078
  • db1077
  • db1075
Marostegui updated the task description. (Show Details)Sep 4 2018, 12:41 PM
gerritbot added a comment.Sep 4 2018, 12:44 PM

Change 450934 merged by Marostegui:
[operations/puppet@production] filtered_tables: Remove unused columns

https://gerrit.wikimedia.org/r/450934

Marostegui updated the task description. (Show Details)Sep 4 2018, 12:44 PM
Marostegui updated the task description. (Show Details)Sep 5 2018, 7:26 AM
Marostegui updated the task description. (Show Details)Sep 5 2018, 8:21 AM
Stashbot added a comment.Sep 14 2018, 7:49 AM

Mentioned in SAL (#wikimedia-operations) [2018-09-14T07:49:20Z] <marostegui> Deploy schema change on s4 eqiad master (db1068) - T67448 T114117 T51191

Marostegui updated the task description. (Show Details)Sep 17 2018, 5:25 AM
Stashbot added a comment.Sep 17 2018, 5:28 AM

Mentioned in SAL (#wikimedia-operations) [2018-09-17T05:28:00Z] <marostegui> Deploy schema change on s1 eqiad master (db1067) - T67448 T114117 T51191

Marostegui updated the task description. (Show Details)Sep 17 2018, 9:05 AM
Marostegui changed the task status from Open to Stalled.Oct 24 2018, 9:55 AM
Marostegui moved this task from In progress to Pending comment on the DBA board.
Marostegui changed the task status from Stalled to Open.Nov 12 2018, 9:08 AM
Marostegui moved this task from Pending comment to In progress on the DBA board.Nov 12 2018, 10:44 AM
Stashbot added a comment.Nov 12 2018, 10:45 AM

Mentioned in SAL (#wikimedia-operations) [2018-11-12T10:45:18Z] <marostegui> Deploy schema change on db2048 (s1 codfw master), this will generate lag on s1 codfw - T51191

Marostegui closed this task as Resolved.Nov 12 2018, 10:59 AM
Marostegui updated the task description. (Show Details)
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits