Page MenuHomePhabricator

VisualEditor: Tables with a faulty <tr> at their end display it, confusing users
Closed, InvalidPublic

Description

See https://en.wikipedia.org/wiki/Daryle_Singletary?veaction=edit - the first three (but strangely, not the last) discography tables.


Version: unspecified
Severity: normal

Details

Reference
bz49691

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 1:58 AM
bzimport added a project: VisualEditor.
bzimport set Reference to bz49691.

This is not a bug (well, it's not a bug with VE :-)) - the three "broken" tables all have

|-
| <content>
|-
|}

… at the end, which is not the case for the third "working" one. What you see is the result of broken wikitext.

VE is good, but it can't be psychic about what you wanted to do with that that extra table row (maybe you wanted to expand the table and were half-way through?) so behaviour is "as intended". Marking as INVALID; in general broken wikitext like this can't be trivially fixed by a bot, due to wikitext's complexities, but it might be worth exploring.

Makes sense. Alternately would it be possible to add it in as a rule to Parsoid's voodo wikimarkup-fixing stuff? If a |- is followed by nothing and then a |}...

(In reply to comment #2)

Makes sense. Alternately would it be possible to add it in as a rule to
Parsoid's voodo wikimarkup-fixing stuff? If a |- is followed by nothing and
then a |}...

But some gadgets might rely on that meaning something special for some users. Everything we change or "fix" potentially breaks things for some (other) users. :-(

This is a Parsoid bug. The PHP parser does not generate a <tr> for this wikitext, and Parsoid does.

(In reply to comment #4)

This is a Parsoid bug. The PHP parser does not generate a <tr> for this
wikitext, and Parsoid does.

Does the PHP parser create it but it then gets tidied away?

(In reply to comment #5)

(In reply to comment #4)

This is a Parsoid bug. The PHP parser does not generate a <tr> for this
wikitext, and Parsoid does.

Does the PHP parser create it but it then gets tidied away?

That's possible, I haven't checked what happens when Tidy is disabled.