Page MenuHomePhabricator

Images: Image insertion uses both the English and the localised syntax for "right"
Closed, ResolvedPublic


Reported initially in bug 49596:

ptwiki ("direita,right"):

plwiki ("prawo,right"):

This feels like a Parsoid issue (VisualEditor doesn't know about localisations of these terms :-)) but Inez can tell us more details.

Version: unspecified
Severity: normal



Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 2:09 AM
bzimport added a project: Parsoid.
bzimport set Reference to bz49849.

Correct - it is a Parsoid bug. Somehow it is similar to but definitely not a duplicate.

winne2i wrote:

It's not a
(localised 'thumb'),right
this is
(localised 'right'),right
as I mentioned in bug 49596 comment 6.

winne2i wrote:

(I also mentioned "/ramka/ means /frame/" but I suppose "ramka" would be localised "thumb"…?)

These magic words are translateable at (for example for Polish) - the entry for "right" says "prawo, right", which means both "prawo" and "right" are accepted and mean the canonical "right".

This looks as if Parsoid was calling (implicitly?) .toString() on an array of these terms instead of taking its first entry: ['prawo', 'right'].toString() == 'prawo,right'.

AFAIC, there is nothing wrong in using the localized version. The problem is to use both.

Related URL: (Gerrit Change I9717e9d4b3b79cc9e583fb74e3537fbb5112a7bf) (Gerrit Change I9717e9d4b3b79cc9e583fb74e3537fbb5112a7bf) | change APPROVED and MERGED [by jenkins-bot]

[Parsoid component reorg by merging JS/General and General. See bug 50685 for more information. Filter bugmail on this comment. parsoidreorg20130704]