Page MenuHomePhabricator

VisualEditor: "Apply changes" label should be replaced with "Insert template/reflist" when inserting template/reflist
Closed, ResolvedPublic

Description

When inserting a new template, the template dialog button label "Apply changes" doesn't make sense, since we're not changing an existing element. In that case, the button should be labeled "Insert template".

Similarly, when inserting the list of references, the button should be labeled "Insert references list", not "Apply changes".

In contrast, when inserting a footnote or media file, the button is correctly labeled "Insert reference" or "Insert media".


Version: unspecified
Severity: minor

Details

Reference
bz50998

Event Timeline

bzimport raised the priority of this task from to Normal.Nov 22 2014, 2:01 AM
bzimport set Reference to bz50998.
Eloquence created this task.Jul 9 2013, 2:29 AM

Change 117342 had a related patch set uploaded by Jforrester:
Keep label and disabled state of transclusion dialog apply button in sync

https://gerrit.wikimedia.org/r/117342

Change 117342 merged by jenkins-bot:
Keep label and disabled state of transclusion dialog apply button in sync

https://gerrit.wikimedia.org/r/117342