Page MenuHomePhabricator

gerrit-wm no longer relays "Change abandoned" and 2+ inline comments events
Closed, ResolvedPublic

Description

Last "Change abandoned" on 2013-06-27:
[12:48:01] <gerrit-wm_> Change abandoned: Euvl; "(no reason)" [mediawiki/extensions/Lingo] (master) - https://gerrit.wikimedia.org/r/70807

Last event with inline comments but no cover review on 2013-06-29:
[20:56:52] <gerrit-wm_> New review: Mwjames; "(1 comment)" [mediawiki/extensions/SemanticInternalObjects] (master) - https://gerrit.wikimedia.org/r/67590

(Grepping curl http://bots.wmflabs.org/~wm-bot/logs/%23wikimedia-dev/%23wikimedia-dev.tar.gz | tar -xzf - )


Version: unspecified
Severity: major
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=46452

Details

Reference
bz51162

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 1:43 AM
bzimport added a project: Gerrit.
bzimport set Reference to bz51162.
bzimport added a subscriber: Unknown Object (MLST).

(In reply to comment #0)

Last event with inline comments but no cover review on 2013-06-29:

Scrap that, it's just the tar.gz not containing July yet... we still see "(1 comment)" events, but the last "(n comments)" event was on 2013-04-24:
[19:57:38] <gerrit-wm> New review: Parent5446; "(7 comments)" [mediawiki/extensions/Echo] (master) C: -1; - https://gerrit.wikimedia.org/r/60689

It surely doesn't make sense to favour 1-comment CR over multiple-comments CR, no way this can be intended.

Yeah, the hook changed, hadn't noticed until I was out. Will take a look.

We *really* need to rewrite these to use stream-events :(

(In reply to comment #2)

We *really* need to rewrite these to use stream-events :(

I hope it's not too complicated. Would that allow to solve bug 46452 too?

Change 74429 had a related patch set uploaded by Demon:
Fix change-abandoned hook

https://gerrit.wikimedia.org/r/74429

Change 74429 abandoned by Demon:
Fix change-abandoned hook

Reason:
gerrit-wm is dead, long live gerrit-wm!

https://gerrit.wikimedia.org/r/74429

Change abandoned has been fixed. +2 inline comments I dunno...how does the bot handle those now?

(In reply to comment #7)

+2 inline comments I dunno...how does the
bot
handle those now?

Might be working, tested with a 2 inline comments review:
18.42 < grrrit-wm> (CR) Nemo bis: "(2 comments)" [core] - https://gerrit.wikimedia.org/r/76289 (owner: Nemo bis)

Seems to be working for me. I got abandoned and +2 notifications recently.