Page MenuHomePhabricator

WikiLove creates pages like User talk:User talk:Subject
Closed, ResolvedPublic

Details

Reference
bz51399

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 1:59 AM
bzimport set Reference to bz51399.
bzimport added a subscriber: Unknown Object (MLST).
Rillke created this task.Jul 15 2013, 9:07 PM

How to reproduce:

POST /w/api.php
action wikilove
format json
message Test
subject A beer for you!
text {| style="background-color: #fdffe7; border: 1px solid #fceb92;" |style="vertical-align: middle; padding: 5px;" | [[File:Export hell seidel steiner.png|70px]] |style="vertical-align: middle; padding: 3px;" | Test ~~~~ |}
title User:User:RillkeBot
token XXX
type food-beer

Response:
{"redirect":{"pageName":"User_talk:User:RillkeBot","fragment":"A_beer_for_you.21"}}

(In reply to comment #1)

title User:User:RillkeBot

This isn't a valid title. Garbage in, garbage out?

(In reply to comment #2)

This isn't a valid title. Garbage in, garbage out?

This may be true but the user does not set the title. This is done by the javascript interface of the extension.

Sorry, I got confused and thought you were manually POSTing. I just confirmed that the interface is broken: https://commons.wikimedia.org/w/index.php?title=User_talk:User:RillkeBot&oldid=100086116.

Was Commons recently updated? Perhaps related to MediaWiki 1.22wmf10.

Change 73871 had a related patch set uploaded by Kaldari:
Reverting change I6d2fa445 to fix regression.

https://gerrit.wikimedia.org/r/73871

Change 73871 merged by jenkins-bot:
Reverting change I6d2fa445 to fix regression.

https://gerrit.wikimedia.org/r/73871

(In reply to comment #6)

Looks like it's probably due to https://gerrit.wikimedia.org/r/#/c/64883

It looks to me like that didn't cause it, it just exposed it. The real problem lies in the Javascript, where it blindly prepends "User:" to each item in the recipients list (ext.wikiLove.core.js line 705) even though the one entry in the default recipient list (ext.wikiLove.core.js line 34) already begins with "User".

Change 73883 had a related patch set uploaded by Hoo man:
Don't construct titles like User:User:Hoo in JS

https://gerrit.wikimedia.org/r/73883

Change 73883 merged by jenkins-bot:
Don't construct titles like User:User:Hoo in JS

https://gerrit.wikimedia.org/r/73883