UploadWizard adding null location template and missing category
Closed, ResolvedPublic

Description

Author: Pi.1415926535.bugzilla

Description:
UploadWizard on Commons is adding {{Location dec|0|0}} to all files - even when the "add location" link is not clicked on the form - and failing to add [[Category:Uploaded with UploadWizard]].


Version: unspecified
Severity: normal
URL: https://commons.wikimedia.org/wiki/Commons:Village_pump#Null_location_templates_added_by_UploadWizard

Details

Reference
bz51879
bzimport set Reference to bz51879.
bzimport created this task.Jul 23 2013, 1:12 PM

I leave it to someone else, hovever, to apply mw's whitespace "conventions".

4a530c4b7341b9bb8409b194469f594f24fb5548 seems to be the culprit by setting the default to "0".

Change 75595 had a related patch set uploaded by Rillke:
Do not pre-fill longitude and latitude inputs with 0 values

https://gerrit.wikimedia.org/r/75595

Change 75597 had a related patch set uploaded by Rillke:
Default value for lon and lat from 0 to empty String

https://gerrit.wikimedia.org/r/75597

Change 75602 had a related patch set uploaded by Rillke:
Update CommonSettings to reflect changes in UpWiz

https://gerrit.wikimedia.org/r/75602

Change 75602 merged by jenkins-bot:
Update CommonSettings to reflect changes in UpWiz

https://gerrit.wikimedia.org/r/75602

Change 75597 merged by jenkins-bot:
Do not set default values for lat and lon

https://gerrit.wikimedia.org/r/75597

For the community: I've filed a bot request at [[:commons:Commons:Bots/Requests/RillkeBot]] for cleaning this up.

Thanks Rillke :)

Change 75595 merged by jenkins-bot:
Clean-up UploadWizardDetails.js

https://gerrit.wikimedia.org/r/75595

Thanks for the code-review. Everything that removed the symptoms (except in upload wizard campaigns that had set their config of lat and lon to 0) is already live.

I do not think that it is fixed:
see e.g. http://commons.wikimedia.org/w/index.php?title=File:Feldkirch_Johannitergasse_6.jpg&oldid=101087802

Still there is

  • {{Location dec|0|0}}
  • and additionally: <strong class="error">Expression error: Unrecognized punctuation character &quot;&quot;.</strong>

if there are exif coords (http://commons.wikimedia.org/w/index.php?title=File:Postmeilenstein_Neudorf_ob_Wildon_20130726.jpg&oldid=101119356) there is as a new effect:
<strong class="error">Expression error: Unrecognized punctuation character &quot;&quot;.</strong>

Rillke added a comment.Aug 2 2013, 3:46 PM

https://commons.wikimedia.org/wiki/Campaign:wlm-at sets
lat 0
lon 0
by default. This was fixed by 268ea6bc599bbe26ef58b89695402f9d506def29 which is not live, yet. The issue only occurs with campaign uploads if the campaign sets 0-defaults.

The error message comes from
{{subst:WLM-is-running|at|{{Wiki Loves Monuments 2013|at}}}}
which is something to be fixed at Commons.

Is this still an issue? We'll mark this resolved next time we touch this unless we see information to the contrary.

(In reply to comment #16)

Is this still an issue? We'll mark this resolved next time we touch this
unless we see information to the contrary.

I do not see any issue at the moment. You can fix it. Thanks for caring.

(In reply to comment #18)

(In reply to comment #16)
> Is this still an issue? We'll mark this resolved next time we touch this
> unless we see information to the contrary.

I do not see any issue at the moment. You can fix it. Thanks for caring.

You can close it, of course.

(In reply to comment #17)
That is not a representative example. I as waiting for https://gerrit.wikimedia.org/r/#/c/75595/ to go live so zero-templates through upload campaigns are also avoided.

It apparently is now.

Gilles moved this task from Untriaged to Done on the Multimedia board.Dec 4 2014, 10:21 AM
Gilles raised the priority of this task from "High" to "Unbreak Now!".
Gilles lowered the priority of this task from "Unbreak Now!" to "High".Dec 4 2014, 11:20 AM

Add Comment