Page MenuHomePhabricator

EventLogging: Schema samples dialog doesn't handle overflow
Closed, ResolvedPublic

Description

Screenshot of schema sample dialog on [[m:Schema:MobileWatchlistInteraction]]

The dialog seems to have a fixed width (30em) and no overflow handling, so the text just overflows out of the bounding box. Should probably allow some extension (min-width, max-width?) and perhaps scroll otherwise (overflow-x: auto).


Version: unspecified
Severity: normal

Attached:

Details

Reference
bz52054

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 1:48 AM
bzimport set Reference to bz52054.
Krinkle created this task.Jul 25 2013, 8:39 PM

Minor things:

  • Red button doesn't have a tooltip
  • Shadow seems a bit excessive
  • Dialog could do with a subtle border
  • Perhaps not use a border radius

Quick hack (use as you see fit): background: #fff; border: 1px solid #ddd; box-shadow: rgba(0, 0, 0, 0.3) 0.3em 0.3em 1em; border-radius: 0;

ori added a comment.Jul 25 2013, 8:54 PM

Krinkle, you're awesome :) Thanks. I'll give that a shot.

Change 84296 had a related patch set uploaded by Ori.livneh:
Improve styling of schema code samples dialog

https://gerrit.wikimedia.org/r/84296

Change 84296 merged by jenkins-bot:
Improve styling of schema code samples dialog

https://gerrit.wikimedia.org/r/84296

[moving from MediaWiki extensions to Analytics product - see bug 61946]