Page MenuHomePhabricator

Some non-table uses of {{pipe}} are not parsed correctly
Closed, ResolvedPublic

Description

Because we parse templates in their own top-level context, the {{pipe}} template gets parsed as <td>... when in most of its uses it really wants to be just a plain pipe character. Eg:

!! test
Plain pipe
!! input
{{pipe}}
!! result

!! end


Version: unspecified
Severity: normal

Details

Reference
bz52363

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 2:10 AM
bzimport set Reference to bz52363.
cscott created this task.Jul 31 2013, 11:09 PM

Change 77352 had a related patch set uploaded by Cscott:
Add parser tests for bug 52468 and bug 52363.

https://gerrit.wikimedia.org/r/77352

Change 77352 merged by jenkins-bot:
Add parser tests for bug 52468 and bug 52363.

https://gerrit.wikimedia.org/r/77352

(In reply to comment #0)

Because we parse templates in their own top-level context, the {{pipe}}
template gets parsed as <td>... when in most of its uses it really wants to
be
just a plain pipe character.

Do you have data to support the 'in most of its uses' claim? I'd be surprised if that was the case.

Perhaps you're confusing {{pipe}} for {{!}} ?

@GWicke and @Technical 13 -- I'm solely talking about parserTests.txt here. I'm making no claims about general wikitext usage.

This has been fixed for a while now. The pipe chars outside tables are handled correctly whether as {{!}} or |