Page MenuHomePhabricator

Disable thank link while waiting for the server's response, to eliminate one cause of accidental double-thanks.
Closed, ResolvedPublic

Description

Author: bsitu

Description:
After I click 'Ok' in the confirmation dialog, the 'thank' link is still clickable if the server is slow to respond, this will result in triggering multiple thanks notifications.

We should have some way to disable the 'thank' link while waiting for server response


Version: master
Severity: normal
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=51303

Details

Reference
bz56378

Event Timeline

bzimport raised the priority of this task from to Needs Triage.
bzimport set Reference to bz56378.
bzimport added a subscriber: Unknown Object (MLST).
bzimport created this task.Oct 30 2013, 5:39 PM
Mattflaschen-WMF triaged this task as Normal priority.Feb 6 2015, 6:47 PM

This is enforced only in JavaScript, so the bug may still be present. Ideally, it would be enforced on the server, but if not, we may be able to make it less likely in JS (at least for multiple clicks before reloading the page).

Mattflaschen-WMF renamed this task from Triggering multiple thanks notification on a single revision to Disable thank link while waiting for the server's response, to eliminate one cause of accidental double-thanks..Mar 4 2015, 1:17 AM
Mattflaschen-WMF set Security to None.
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptJun 22 2015, 9:15 PM

This is still technically possible after rETHA956a47600534: Use log_search to track already sent thanks since we create the EchoEvent before writing the log entry. We could use some kind of locking system to prevent it I guess...