Page MenuHomePhabricator

About and feedback links should not jump around when image is loaded
Closed, ResolvedPublic

Description

Media-Viewer-Bug-About-Links-Screenshot

When you click on a thumbnail to open up the light box, the 'About Media Viewer' and 'Leave feedback' links show up while the image is loading, as seen in the attached screenshot.

They should only appear once image is loaded, like all of the other information.


Version: unspecified
Severity: normal

Attached:

Media-Viewer-Bug-About-Links-Screenshot.png (1×1 px, 1 MB)

Details

Reference
bz56447

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:27 AM
bzimport added a project: MediaViewer.
bzimport set Reference to bz56447.
bzimport added a subscriber: Unknown Object (MLST).

If the image is broken and never loads, I'd still like to be able to get at the information and feedback page surely?

That's exactly the sort of thing one would want to leave feedback about. :)

I notice that there seems to be no fixed-size placeholder for the not-yet-loaded image, which causes those links to appear much higher up while the spinner is being shown than after the image gets inserted.

Recommend either using some absolute positioning or just setting a placeholder of the desired dimensions so things don't go jumping around after the image loads.

These should be hidden before load now, and should be below the fold of the new interface anyway, so I'm going to close - please reopen if you see this again.

Gilles raised the priority of this task from Medium to Unbreak Now!.Dec 4 2014, 10:24 AM
Gilles moved this task from Untriaged to Done on the Multimedia board.
Gilles lowered the priority of this task from Unbreak Now! to Medium.Dec 4 2014, 11:23 AM