Page MenuHomePhabricator

VisualEditor: Demote the "New Page" part of the link inspector to below the "External link" one when inserting a link as URL pattern
Closed, ResolvedPublic

Description

Difference in the view mode

Steps to reproduce:

1.Click on the Edit-beta button
2.Type a text to apply link on it, For example: CNN
3.Now click on the link icon from the tool bar or press ctrl+k/ Command+K
4.Now type the link as http://cnn.com as an external link.
5.Now type again another text CNN
6.Now apply link insertion onto it as : http://cnn.com as new page
7.Press the button "Save"

Observed Result:
Now observe that the link created in step 4 looks reasonable to have an external
link when the URL is specific in the link inspector.
But user wont usually want a new page while specifying the URL itself and might accidentally to do that without any intention to do that.

Also, observe the output format of step 6 looks wrong as the wiki markup for link shows up in the CE in view mode with a number.Though functionally, it works same as a link to external page.

Expected Result:
As a suggestion,collapse the "New Page" part of the link inspector when a URL pattern detected.

See the screenshot attached.


Version: unspecified
Severity: enhancement

Attached:

Screen_Shot_2013-11-01_at_11.50.46_AM.png (248×539 px, 29 KB)

Details

Reference
bz56482

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:30 AM
bzimport set Reference to bz56482.

Also, if I review my changes it shows the attached format.

Created attachment 13657
Difference in the review mode

Attached:

Screen_Shot_2013-11-01_at_12.19.54_PM.png (411×631 px, 32 KB)

We don't want to do this, because "http://www.amazon.com" is a valid page name and someone might actually want to use it - for example, [[en:Http://]] is a page (specifically, a redirect to the HTTP article).

However, maybe we should demote the "new" section below the external link one, to make it clearer?

(In reply to James Forrester from comment #3)

We don't want to do this, because "http://www.amazon.com" is a valid page
name and someone might actually want to use it - for example, [[en:Http://]]
is a page (specifically, a redirect to the HTTP article).

However, maybe we should demote the "new" section below the external link
one, to make it clearer?

It looks like this has already been done? Am I missing something?

(In reply to Alex Monk from comment #4)

(In reply to James Forrester from comment #3)

We don't want to do this, because "http://www.amazon.com" is a valid page
name and someone might actually want to use it - for example, [[en:Http://]]
is a page (specifically, a redirect to the HTTP article).

However, maybe we should demote the "new" section below the external link
one, to make it clearer?

It looks like this has already been done? Am I missing something?

You're completely right, we did this a while ago. Never mind me! Sorry for wasting your time. :-(