Page MenuHomePhabricator

Rollback notification doesn't check if it was a null revert
Closed, ResolvedPublic

Description

The revert notification is triggered even if the rollback does nothing (current version is equal to the one being reverted to).

Just need to check that the content of both revisions are not equal before sending the notification.


Version: unspecified
Severity: normal
URL: https://en.wikipedia.org/w/index.php?title=Wikipedia_talk:Notifications&oldid=580155465#Incorrect_notification_about_a_self-revert
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=54007

Details

Reference
bz56574

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:37 AM
bzimport set Reference to bz56574.

Change 95797 had a related patch set uploaded by Alex Monk:
Don't send rollback notification if nothing changed

https://gerrit.wikimedia.org/r/95797

Change 95797 merged by jenkins-bot:
Don't send rollback notification if nothing changed

https://gerrit.wikimedia.org/r/95797