Page MenuHomePhabricator

"Unlock further protect options" doesn't work due to JS deprecations
Closed, ResolvedPublic

Description

At least one core caller of the to-be-deprecated functions was missed before Gerrit change 92457 was merged: skins/common/protect.js (line 42) calls addClickHandler. Now that addClickHandler is nooped, clicking the checkbox no longer changes the form state.


Version: 1.22.0
Severity: normal
URL: https://test.wikipedia.org/wiki/Page393?action=protect&debug=true

Details

Reference
bz56726

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:16 AM
bzimport set Reference to bz56726.
Anomie created this task.Nov 7 2013, 5:03 PM
Anomie added a comment.Nov 7 2013, 5:05 PM

I also see some calls to injectSpinner and removeSpinner in ./skins/common/upload.js.

Change 94161 had a related patch set uploaded by Krinkle:
Migrate usage of legacy wikibits in core

https://gerrit.wikimedia.org/r/94161

Change 94161 merged by jenkins-bot:
Migrate usage of wikibits in legacy protect.js and upload.js

https://gerrit.wikimedia.org/r/94161

Change 94235 had a related patch set uploaded by Anomie:
Migrate usage of wikibits in legacy protect.js and upload.js

https://gerrit.wikimedia.org/r/94235

Change 94236 had a related patch set uploaded by Anomie:
Migrate usage of wikibits in legacy protect.js and upload.js

https://gerrit.wikimedia.org/r/94236

Change 94235 merged by jenkins-bot:
Migrate usage of wikibits in legacy protect.js and upload.js

https://gerrit.wikimedia.org/r/94235

Change 94236 merged by jenkins-bot:
Migrate usage of wikibits in legacy protect.js and upload.js

https://gerrit.wikimedia.org/r/94236

Anomie added a comment.Nov 7 2013, 9:24 PM

Change merged, backported to wmf branches, and deployed.

Change 94256 had a related patch set uploaded by Bartosz Dziewoński:
Migrate usage of wikibits in legacy protect.js and upload.js

https://gerrit.wikimedia.org/r/94256

Change 94256 merged by jenkins-bot:
Migrate usage of wikibits in legacy protect.js and upload.js

https://gerrit.wikimedia.org/r/94256