Page MenuHomePhabricator

Remove gadget modules from mw.loader.store when the user disables them
Open, LowPublic

Description

  1. Go to https://test.wikipedia.org/wiki/Special:Preferences#mw-prefsection-gadgets and disable all gadgets except one which is loaded by ResourceLoader (e.g. "ShortDiff"), then save your changes
  2. Clear you browser cache and local storage
  3. Go to https://test.wikipedia.org/wiki/Special:BlankPage and take note of the list of gadget modules in the store:
$.grep( Object.keys( mw.loader.store.items ), function( m ){
    return m.indexOf( 'ext.gadget' ) !== -1; }
).join( '\n' )

In my case, this returned:

ext.gadget.ShortDiff@1347062400
  1. Go back to https://test.wikipedia.org/wiki/Special:Preferences#mw-prefsection-gadgets and disable that gadget, and save your changes
  2. Check the list of modules in the storage again.
    • Expected result: The module of the gadget should be removed from local storage
    • Actual result: The module is still there, taking space

See Also: T66721: mw.loader.store should not occupy all of localStorage

Details

Reference
bz56778

Event Timeline

bzimport raised the priority of this task from to Normal.Nov 22 2014, 2:19 AM
bzimport added a project: MediaWiki-JavaScript.
bzimport set Reference to bz56778.
bzimport added a subscriber: Unknown Object (MLST).
He7d3r created this task.Nov 8 2013, 2:08 PM
matmarex updated the task description. (Show Details)Dec 31 2014, 10:08 PM
matmarex set Security to None.
matmarex removed a subscriber: Unknown Object (MLST).
Krinkle moved this task from Backlog to Accepted: Enhancement on the MediaWiki-ResourceLoader board.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 19 2015, 1:40 PM
putnik added a subscriber: putnik.Mar 3 2016, 7:23 PM
Krinkle renamed this task from Remove gadget modules from local storage when the user disables them to Remove gadget modules from mw.loader.store when the user disables them.Mar 24 2016, 6:38 PM
Krinkle updated the task description. (Show Details)Nov 17 2016, 8:13 PM
Krinkle lowered the priority of this task from Normal to Low.Dec 3 2016, 5:25 AM