Page MenuHomePhabricator

Flow: Change logging to LifecycleHandler
Closed, ResolvedPublic

Description

To save log entries, Topic.php will do a $logger->log() call. It'd be better to have logging work similar to RC (Flow\Data\RecentChanges)

This was initially not possible, because:

  • moderation notes are needed in log, but not saved in revision object (see bug 57055)
  • action names were not accessible

The latter has already been addressed; AbstractRevision::getChangeType() should return an action name that is known by FlowActions, so the relevant logging data ('log_type') can be fetched.

Once bug 57055 is resolved, we should probably be able to improve this.


Version: unspecified
Severity: normal

Details

Reference
bz57056

Related Objects

StatusSubtypeAssignedTask
ResolvedNone
ResolvedNone

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:39 AM
bzimport set Reference to bz57056.
bzimport added a subscriber: Unknown Object (MLST).

The WMF core features team tracks this bug on Mingle card https://mingle.corp.wikimedia.org/projects/flow/cards/462, but people from the community are welcome to contribute here and in Gerrit.

Change 95985 had a related patch set uploaded by Werdna:
[SCHEMA CHANGE] Refactor of moderation logging.

https://gerrit.wikimedia.org/r/95985

Change 95985 merged by jenkins-bot:
[SCHEMA CHANGE] Refactor of moderation logging.

https://gerrit.wikimedia.org/r/95985