Page MenuHomePhabricator

Move 'X' Icon to upper right corner in Media Viewer
Closed, ResolvedPublic

Description

The 'X' close icon in the Media Viewer is now shown at the top right corner of the image, even if there is plenty of room in the browser window around it. This unnecessarily clutters the image.

Instead, we should showin the 'X' icon at the top right corner of the browser window -- above the 'Next' right arrow.

(Also note that either icon should not be right against the edge, but a few pixels away from it, as recommended by Pau Giner.)


Version: unspecified
Severity: normal

Details

Reference
bz58653

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 2:33 AM
bzimport added a project: MediaViewer.
bzimport set Reference to bz58653.

A mock would be helpful here.

I'll take this one, particularly because I know what they're talking about and it's high priority for us.

Change 104131 had a related patch set uploaded by MarkTraceur:
Move 'x' button, shift arrows away from screen edges

https://gerrit.wikimedia.org/r/104131

Change 104131 merged by jenkins-bot:
Move 'x' button, shift arrows away from screen edges

https://gerrit.wikimedia.org/r/104131

Assuming this bug is FIXED as patch in comment 4 was merged.
If that is not the case: Please reopen and elaborate what is left to do here to get this report fixed.

Confirmed, thanks Andre.

Gilles raised the priority of this task from High to Unbreak Now!.Dec 4 2014, 10:11 AM
Gilles moved this task from Untriaged to Done on the Multimedia board.
Gilles lowered the priority of this task from Unbreak Now! to High.Dec 4 2014, 11:22 AM