Page MenuHomePhabricator

Get rid of $wgFlowParsoidTitle / using $wgTitle
Closed, ResolvedPublic

Description

From the code itself:

/*

  • $wgFlowParsoidTitle is an ugly hack. As long as posts only appear on 1
  • page, we can just omit $title parameter & fallback to $wgTitle.
  • For API calls, however, $wgTitle will not contain the Title
  • object for the page we're submitting Flow changes. That's where
  • $wgFlowParsoidTitle comes in to play, which will be set from API to
  • container the correct Title object. *
  • We should definitely think about a nicer way to pass the correct
  • title to this method, from wherever it is being called from. */

Using $wgTitle is already bad, working around the fact the API doesn't set it is blegh.


Version: unspecified
Severity: normal

Details

Reference
bz58664

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 2:34 AM
bzimport set Reference to bz58664.
bzimport added a subscriber: Unknown Object (MLST).
Legoktm created this task.Dec 18 2013, 7:55 PM

bingle-admin wrote:

The WMF core features team tracks this bug on Mingle card https://mingle.corp.wikimedia.org/projects/flow/cards/637, but people from the community are welcome to contribute here and in Gerrit.

There's currently a patch for this, but it has downsides:

https://gerrit.wikimedia.org/r/#/c/97060/

Basically the patch always loads entire topics, rather than occasionally loading just the topic title and the requested post. Going in this direction we would most likely want to also flush out a second idea from gwicke: store a topic, all its posts, and all relevant metadata as an xml document. Then when you want a complete topic you just grab the most recent xml. As you can imagine thats quite a large refactor though, we havn't figured out if we should tackle it or not.

Change 115112 had a related patch set uploaded by Matthias Mullie:
Non-hacky way to feed title to Parsoid

https://gerrit.wikimedia.org/r/115112

Change 116085 had a related patch set uploaded by Matthias Mullie:
Non-hacky way to feed title to Redlinker

https://gerrit.wikimedia.org/r/116085

Change 115112 merged by jenkins-bot:
Non-hacky way to feed title to Parsoid

https://gerrit.wikimedia.org/r/115112

Change 116085 abandoned by EBernhardson:
Non-hacky way to feed title to Redlinker

Reason:
alternate implementation was merged

https://gerrit.wikimedia.org/r/116085

All patches mentioned in this report are either merged or abandoned - is there more work left to do here (if yes: please reset the bug report status to NEW or ASSIGNED), or can you close this ticket as RESOLVED FIXED?

No reply to comment 7 - assuming this bug is FIXED.
If that is not the case: Please reopen and elaborate what is left to do here to get this report fixed.

Sorry, this looks fixed to me:

km-mpb:Flow km$ ack wgTitle
tests/ContainerTest.php
13: $this->setMwGlobals( 'wgTitle', \Title::newMainPage() );
km-mpb:Flow km$ ack FlowParsoidTitle