Page MenuHomePhabricator

Echo flyout broken in CologneBlue skin
Closed, ResolvedPublic

Description

Screenshot

See the attache screenshot. Because the 0 icon is on the left side, part of the flyout is chopped off.

As a temporary fix, I think we should just disable the flyout on the CologneBlue skin. Eventually it would be cool to have the flyout work, but that might be a lot of work.


Version: unspecified
Severity: normal

Attached:

Screen_Shot_2013-12-19_at_9.06.52_PM.PNG (792×1 px, 451 KB)

Details

Reference
bz58728

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:38 AM
bzimport added a project: Notifications.
bzimport set Reference to bz58728.
bzimport added a subscriber: Unknown Object (MLST).

Sounds reasonable to me. We should probably only show the flyout if the badge appears within, say, top 20% of screen height.

(But we could get the "pokey" to be dynamic, moving the whole box left or right to always fit on-screen.)

Change 103099 had a related patch set uploaded by Bartosz Dziewoński:
Make sure the overlay is visible, even if the badge is near the edge

https://gerrit.wikimedia.org/r/103099

Change 103100 had a related patch set uploaded by Bartosz Dziewoński:
Don't show the overlay if the badge is not near the top of the window

https://gerrit.wikimedia.org/r/103100

Change 103099 merged by jenkins-bot:
Make sure the overlay is visible, even if the badge is near the edge

https://gerrit.wikimedia.org/r/103099

Change 103100 merged by jenkins-bot:
Don't show the overlay if the badge is not near the top of the window

https://gerrit.wikimedia.org/r/103100