Page MenuHomePhabricator

Beta tag ({{int:visualeditor-beta-appendix}}) should not always be displayed in the guider description
Closed, ResolvedPublic

Description

Author: swalling

Description:
Francais

Edit beta is specific to English Wikipedia but we hard coded it in the tour text for GettingStarted, so it is showing up incorrectly in translated versions such as French etc.


Version: unspecified
Severity: normal

Attached:

Details

Reference
bz61321

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:50 AM
bzimport set Reference to bz61321.

It's easy to detect if this is enabled (mw.config.get( 'wgVisualEditorConfig' ).tabMessages). However, I need to decide whether to make separate messages or substitute it in.

Is this an acceptable use of a parameter (passing either '{{int:vector-view-edit}} {{int:visualeditor-beta-appendix}}"' or '{{int:vector-view-edit}}' depending on configuration?

Or should I make separate messages?

(In reply to Matthew Flaschen from comment #1)

It's easy to detect if this is enabled (mw.config.get(
'wgVisualEditorConfig' ).tabMessages). However, I need to decide whether to
make separate messages or substitute it in.

Can you pass two messages to it directly?

Is this an acceptable use of a parameter (passing either
'{{int:vector-view-edit}} {{int:visualeditor-beta-appendix}}"' or
'{{int:vector-view-edit}}' depending on configuration?
Or should I make separate messages?

If the message(s) are just '{{int:vector-view-edit}} {{int:visualeditor-beta-appendix}}' it's not less lego to have two. You can pass to the tab a message '{{int:vector-view-edit}}$1" where $1 is nothing or " {{int:visualeditor-beta-appendix}}".

(In reply to Nemo from comment #2)

(In reply to Matthew Flaschen from comment #1)

It's easy to detect if this is enabled (mw.config.get(
'wgVisualEditorConfig' ).tabMessages). However, I need to decide whether to
make separate messages or substitute it in.

Can you pass two messages to it directly?

Sorry, I'm a little unclear what you mean. What would the two messages be, and what would I pass them to?

If the message(s) are just '{{int:vector-view-edit}}
{{int:visualeditor-beta-appendix}}' it's not less lego to have two. You can
pass to the tab a message '{{int:vector-view-edit}}$1" where $1 is nothing
or " {{int:visualeditor-beta-appendix}}".

I'm not controlling the text of the tab (sorry, the bug title was misleading). I'm controlling the text of the guider (a kind of modal popup), which refers to the text of the tab.

However, I think your suggestion of using a parameter just for the second part could still apply.

See the attachment for the issue. Note how the guider says "Modifier bêta", but the actual tab just says "Modifier". We want to fix the guider to check the configuration and always match the tab.

This is in a firsteditve message in the GuidedTour extension.

Change 114698 had a related patch set uploaded by Mattflaschen:
Use VisualEditor configuration for appendices (e.g. beta).

https://gerrit.wikimedia.org/r/114698

Change 114698 merged by Phuedx:
Use VisualEditor configuration for appendices (e.g. beta).

https://gerrit.wikimedia.org/r/114698